-
Notifications
You must be signed in to change notification settings - Fork 0
Add steps argument to Predator Prey exercise code #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Argument is mandatory, and requires a positive integer, previously defaulted to 250 Closes #83
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/RSE-Sheffield/pando-python/compare/md-outputs..md-outputs-PR-84 The following changes were observed in the rendered markdown documents: What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2025-05-10 19:22:24 +0000 |
JostMigenda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some minor bits of cleanup.
Co-authored-by: Jost Migenda <jost.migenda@kcl.ac.uk>
Co-authored-by: Jost Migenda <jost.migenda@kcl.ac.uk>
|
Thanks for the brilliant review as always @JostMigenda, I obviously did a low effort job putting this together given I didn't even catch the fact I should Happy for you to approve and squash. |
Auto-generated via `{sandpaper}`
Source : 0c6e8b6
Branch : main
Author : Robert Chisholm <robert.chisholm@sheffield.ac.uk>
Time : 2025-05-11 01:29:42 +0000
Message : Add steps argument to Predator Prey exercise code (#84)
* Add steps argument to Predator Prey exercise code
Argument is mandatory, and requires a positive integer, previously defaulted to 250
Closes #83
* Update episodes/profiling-lines.md
Co-authored-by: Jost Migenda <jost.migenda@kcl.ac.uk>
* Update episodes/files/pred-prey/predprey.py
Co-authored-by: Jost Migenda <jost.migenda@kcl.ac.uk>
* Jost review suggestions
---------
Co-authored-by: Jost Migenda <jost.migenda@kcl.ac.uk>
Auto-generated via `{sandpaper}`
Source : 5bcb048
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2025-05-11 01:30:41 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 0c6e8b6
Branch : main
Author : Robert Chisholm <robert.chisholm@sheffield.ac.uk>
Time : 2025-05-11 01:29:42 +0000
Message : Add steps argument to Predator Prey exercise code (#84)
* Add steps argument to Predator Prey exercise code
Argument is mandatory, and requires a positive integer, previously defaulted to 250
Closes #83
* Update episodes/profiling-lines.md
Co-authored-by: Jost Migenda <jost.migenda@kcl.ac.uk>
* Update episodes/files/pred-prey/predprey.py
Co-authored-by: Jost Migenda <jost.migenda@kcl.ac.uk>
* Jost review suggestions
---------
Co-authored-by: Jost Migenda <jost.migenda@kcl.ac.uk>
Argument is mandatory, and requires a positive integer, previously defaulted to 250.
Minimal args in similar style to earlier travelling sales person script.
Closes #83