Skip to content

Changes for release node/v0.5.2#109

Merged
bvscd merged 7 commits into
release/node/v0.5.2from
node/v0.5.2
Apr 21, 2026
Merged

Changes for release node/v0.5.2#109
bvscd merged 7 commits into
release/node/v0.5.2from
node/v0.5.2

Conversation

@bvscd
Copy link
Copy Markdown
Collaborator

@bvscd bvscd commented Apr 21, 2026

No description provided.

Copilot AI review requested due to automatic review settings April 21, 2026 00:42
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables fast sync overlays to use two-step broadcast with QUIC reliability, and refactors semi-private overlays to distinguish validator ADNL IDs from validator signing public keys (for certificate verification).

Changes:

  • Extend semi-private overlay creation to accept both root_adnl_ids and root_public_keys, plus a use_quic flag.
  • Update fast sync overlay routing to include prev/this/next validator sets as roots and optionally send via two-step broadcast.
  • Add client helpers to send two-step broadcasts and plumb QUIC enablement through overlay types.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/node/src/network/overlay_client.rs Updates semi-private overlay creation parameters and adds broadcast_twostep wrapper.
src/node/src/network/full_node_overlays.rs Passes QUIC settings + expanded root validator set into fast sync overlays; conditionally uses two-step broadcast.
src/node/src/network/fast_sync_overlay_client.rs Builds root ADNL/public key lists, toggles two-step/QUIC usage, and adds send_twostep_broadcast.
src/adnl/tests/test_overlay.rs Adjusts semi-private overlay tests to new add_semiprivate_overlay signature.
src/adnl/src/overlay/mod.rs Refactors certified-member overlay state, adds QUIC support for it, and filters two-step neighbours to root validators.
Comments suppressed due to low confidence (1)

src/node/src/network/full_node_overlays.rs:476

  • update_fast_sync_overlays now takes mc_use_quic / shard_use_quic, but the early-return condition only checks monitor_min_split and validators_changed. If QUIC config changes while those stay the same, overlays won't be recreated and the new setting won’t take effect. Consider tracking the previous QUIC settings (e.g., store them alongside monitor_min_split_for_fast_sync) and include them in the change detection logic.
        let mut cur_validators = self.validators.lock().await;
        let validators_changed = *cur_validators != *this_validators;
        let old_monitor_min_split = self.monitor_min_split_for_fast_sync.load(Ordering::Relaxed);
        if (old_monitor_min_split == new_monitor_min_split) && !validators_changed {
            return Ok(());
        }

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/adnl/src/overlay/mod.rs
Comment thread src/adnl/src/overlay/mod.rs
@bvscd bvscd changed the title Fast sync overlays over QUIC release/node:v0.5.2 Apr 21, 2026
@bvscd bvscd changed the title release/node:v0.5.2 Changes for release node/v0.5.2 Apr 21, 2026
@bvscd bvscd changed the base branch from master to release/node/v0.5.2 April 21, 2026 10:28
@bvscd bvscd merged commit a2ba8a3 into release/node/v0.5.2 Apr 21, 2026
5 checks passed
@bvscd bvscd deleted the node/v0.5.2 branch April 21, 2026 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants