Keep permanent ADNL validator keys#118
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts validator key rotation to retain ADNL validator keys that are still referenced by other elections, preventing premature cleanup of shared ADNL/QUIC/DHT state.
Changes:
- Refactors
revision_validator_keyscontrol flow using early returns and increases the “no rotation” threshold to 3 keys. - Removes oldest validator key when exceeding the threshold, but conditionally skips ADNL key removal if still referenced.
- Emits
RemoveValidatorAdnlKeyevents only when the ADNL key is actually removed.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cleverfox
approved these changes
Apr 23, 2026
cleverfox
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.