Optimize QUIC for high latency links#119
Merged
Merged
Conversation
cleverfox
approved these changes
Apr 23, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the ADNL QUIC transport configuration to better suit high-latency links and simplifies stream-concurrency handling by relying more on quinn’s transport-level limits, with call-site and test updates across node components.
Changes:
- Configure QUIC transport to use BBR congestion control (client + server).
- Add UDP socket offload capability probing (GSO/GRO/may_fragment) during endpoint creation.
- Remove the per-connection stream semaphore / constructor parameter and update all
QuicNode::newcall sites; adjust QUIC tests accordingly.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/adnl/src/quic/mod.rs |
Adds BBR + UDP caps probe; removes per-connection stream semaphore and updates QUIC connection handling. |
src/adnl/tests/test_quic.rs |
Updates QuicNode::new usage, refactors helper creation, and removes the stream-limit test tied to the removed semaphore. |
src/node/src/network/node_network.rs |
Updates QuicNode::new call to match the new signature. |
src/node/consensus-common/src/node_test_network.rs |
Updates QuicNode::new call to match the new signature. |
src/node/tests/compat_test/src/test_helpers.rs |
Updates QuicNode::new call to match the new signature. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.