Skip to content

Optimize QUIC for high latency links#119

Merged
bvscd merged 1 commit into
release/node/v0.5.3from
fix_quic
Apr 23, 2026
Merged

Optimize QUIC for high latency links#119
bvscd merged 1 commit into
release/node/v0.5.3from
fix_quic

Conversation

@bvscd
Copy link
Copy Markdown
Collaborator

@bvscd bvscd commented Apr 23, 2026

No description provided.

Copilot AI review requested due to automatic review settings April 23, 2026 10:52
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the ADNL QUIC transport configuration to better suit high-latency links and simplifies stream-concurrency handling by relying more on quinn’s transport-level limits, with call-site and test updates across node components.

Changes:

  • Configure QUIC transport to use BBR congestion control (client + server).
  • Add UDP socket offload capability probing (GSO/GRO/may_fragment) during endpoint creation.
  • Remove the per-connection stream semaphore / constructor parameter and update all QuicNode::new call sites; adjust QUIC tests accordingly.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/adnl/src/quic/mod.rs Adds BBR + UDP caps probe; removes per-connection stream semaphore and updates QUIC connection handling.
src/adnl/tests/test_quic.rs Updates QuicNode::new usage, refactors helper creation, and removes the stream-limit test tied to the removed semaphore.
src/node/src/network/node_network.rs Updates QuicNode::new call to match the new signature.
src/node/consensus-common/src/node_test_network.rs Updates QuicNode::new call to match the new signature.
src/node/tests/compat_test/src/test_helpers.rs Updates QuicNode::new call to match the new signature.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/adnl/src/quic/mod.rs
Comment thread src/adnl/src/quic/mod.rs
Comment thread src/adnl/src/quic/mod.rs
Comment thread src/adnl/tests/test_quic.rs
@bvscd bvscd merged commit 1d316f1 into release/node/v0.5.3 Apr 23, 2026
15 checks passed
@bvscd bvscd deleted the fix_quic branch April 23, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants