Skip to content

ADNL key management for fast sync overlay#134

Merged
bvscd merged 1 commit into
release/node/v0.6.1from
fix_keys
May 5, 2026
Merged

ADNL key management for fast sync overlay#134
bvscd merged 1 commit into
release/node/v0.6.1from
fix_keys

Conversation

@bvscd
Copy link
Copy Markdown
Collaborator

@bvscd bvscd commented May 5, 2026

No description provided.

Copilot AI review requested due to automatic review settings May 5, 2026 22:57
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds shared ADNL peer address resolution logic and wires it into fast-sync and custom overlays, improving overlay peer discovery while also extending RLDP diagnostics for long-running/timeout-masked transfers.

Changes:

  • Introduced a reusable background “overlay peer resolver” task in NodeNetwork that DHT-resolves peer ADNL addresses and registers them in ADNL via the overlay layer.
  • Integrated the resolver into fast-sync overlay updates (with cancellation management) and refactored custom overlays to use the shared resolver instead of a local worker.
  • Added additional RLDP warnings to diagnose transfers that appear to “mask” timeouts or run excessively long.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
src/node/src/network/node_network.rs Adds a generic, cancelable overlay peer resolver and its per-round resolve helper.
src/node/src/network/full_node_overlays.rs Schedules/cancels fast-sync peer resolution; adjusts local validator key selection across prev/this/next sets.
src/node/src/network/custom_overlay_client.rs Removes bespoke peer-resolve worker and reuses NodeNetwork resolver.
src/adnl/src/rldp/mod.rs Adds new diagnostic WARN logs for long-running RLDP receive/send scenarios and masked-timeout conditions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/node/src/network/node_network.rs
Comment thread src/node/src/network/node_network.rs
Comment thread src/node/src/network/node_network.rs
Comment thread src/node/src/network/full_node_overlays.rs
@bvscd bvscd merged commit 99e166b into release/node/v0.6.1 May 5, 2026
15 checks passed
@bvscd bvscd deleted the fix_keys branch May 5, 2026 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants