ADNL key management for fast sync overlay#134
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds shared ADNL peer address resolution logic and wires it into fast-sync and custom overlays, improving overlay peer discovery while also extending RLDP diagnostics for long-running/timeout-masked transfers.
Changes:
- Introduced a reusable background “overlay peer resolver” task in
NodeNetworkthat DHT-resolves peer ADNL addresses and registers them in ADNL via the overlay layer. - Integrated the resolver into fast-sync overlay updates (with cancellation management) and refactored custom overlays to use the shared resolver instead of a local worker.
- Added additional RLDP warnings to diagnose transfers that appear to “mask” timeouts or run excessively long.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/node/src/network/node_network.rs |
Adds a generic, cancelable overlay peer resolver and its per-round resolve helper. |
src/node/src/network/full_node_overlays.rs |
Schedules/cancels fast-sync peer resolution; adjusts local validator key selection across prev/this/next sets. |
src/node/src/network/custom_overlay_client.rs |
Removes bespoke peer-resolve worker and reuses NodeNetwork resolver. |
src/adnl/src/rldp/mod.rs |
Adds new diagnostic WARN logs for long-running RLDP receive/send scenarios and masked-timeout conditions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Lapo4kaKek
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.