Stability improvements for compressed BOCs and external messages#150
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves stability around compressed BOC handling, RPC request sizing, and external-message pool lifecycle behavior in the node/collator path.
Changes:
- Adds BOC decompression/compression safeguards for empty input, special-cell data length, and improved-structure node/root count caps.
- Changes external-message completion to operate on raw message IDs, postponing accepted messages and deleting rejected messages without norm-hash sibling cleanup.
- Adds JSON-RPC/REST body size limits and updates related tests for postponed-message generation timing and BOC node-count limits.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/block/src/boc_compression.rs |
Adds improved BOC node/root count caps and safer top-level decompression handling. |
src/block/src/cell/builder.rs |
Adds length checks before Merkle proof/update hash slicing. |
src/block/src/tests/test_boc_compression.rs |
Adds regression coverage for improved BOC node-count limits. |
src/node/src/ext_messages.rs |
Updates external-message admission, completion, postponement, cleanup, and iterator behavior. |
src/node/src/rpc_server/mod.rs |
Adds request body size limits and payload-too-large rejection handling. |
src/node/src/validator/collator.rs |
Routes accepted external messages to delay and rejected ones to raw-ID deletion. |
src/node/src/engine_traits.rs |
Updates external-message completion trait signature to use ID slices. |
src/node/src/engine_operations.rs |
Adapts engine implementation to the new completion signature. |
src/node/bin/hardfork.rs |
Adapts mock engine implementation to the new completion signature. |
src/node/src/tests/test_helper.rs |
Adapts test engine implementation to the new completion signature. |
src/node/src/validator/tests/test_collator.rs |
Adapts collator test engine implementation to the new completion signature. |
src/node/src/collator_test_bundle.rs |
Adapts collator test bundle implementation to the new completion signature. |
src/node/src/tests/test_ext_messages.rs |
Updates postponement timing expectations and completion calls. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sumrachek
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.