ci(nodectl): install openssl on windows runner for release build#153
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the nodectl release workflow so the Windows release build can find and statically link OpenSSL via vcpkg.
Changes:
- Adds a Windows-only OpenSSL installation step using
vcpkg. - Exports
OPENSSL_DIRandOPENSSL_STATIC=1before the Cargo release build.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ITBear
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The Windows binary for
nodectlfailed to build in thePublish nodectlworkflow:https://github.com/RSquad/ton-rust-node/actions/runs/26028077294/job/76506563675
openssl-sys v0.9.112could not locate an OpenSSL installation on thewindows-latestrunner (noOPENSSL_DIR, noVCPKG_ROOT), while the workflow only installslibssl-devon Linux.Change
Add a Windows-only step to
.github/workflows/nodectl-release.ymlthat installs OpenSSL via vcpkg using thex64-windows-static-mdtriplet and exposesOPENSSL_DIR+OPENSSL_STATIC=1to the cargo build. Result: the resultingnodectl.exeis statically linked against OpenSSL (no DLL dependency for end users), and vcpkg's OpenSSL build keeps the architectural assembly paths so runtime CPU dispatch still works.No cache is added on purpose — the Windows release runs only on tags (~once every two weeks), so the ~6 min vcpkg install is acceptable in exchange for a simpler workflow.
Other targets are untouched.