Secrets-vault migration fixes for nodectl v0.5.0#166
Merged
Keshoid merged 10 commits intoMay 21, 2026
Conversation
* Refactoring. Fix list_metadata API and fix HashiCorp storage cleanup
ITBear
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bundles upstream
secrets-vaultmigration fixes with the correspondingnodectl key migrateadjustments for the v0.5.0 release.secrets-vault: fix HashiCorplist-keybug; allow migrating non-extractable secrets from file to HashiCorp by going through the storage layer (load_for_migrate+store(..., override_extractable)).nodectl key migrate: port the new migration logic — restrict source tofile://and destination tohashicorp://, propagate the originalextractableflag, remove the deadNOT_EXTRACTABLEskip branch.run_singlehost_nodectl.pynow readsVAULT_URL/VAULT_URL_NODE_Xfrom the environment so the harness can target Hashicorp.