feat(nodectl): settings mutations via REST API by Keshoid · Pull Request #91 · RSquad/ton-rust-node

Keshoid · 2026-04-15T11:49:38Z

Summary

Part 3 of centralizing config management. Moves all settings mutation commands to REST API endpoints.

Unified POST /v1/elections/settings replaces /v1/stake_strategy, individual tick-interval and max-factor endpoints. Accepts any combination of policy, tick_interval, max_factor in one request.
Unified POST /v1/ton-http-api with append flag replaces separate set/add endpoints
POST /v1/log for log settings mutation
Added save_to_file() to elections exclude/include handlers for persistence consistency
Removed config stake-policy CLI alias (use config elections stake-policy)
Service loop rebuilds caches (wallets, pools, RPC client) immediately on entity/endpoint mutations via Notify + force_reload()

Breaking changes

config ton-http-api: renamed --url option to --endpoint (disambiguates from the root config --url option). Update any scripts/automation invoking nodectl config ton-http-api --url ... to use --endpoint.

CI script

Moved config ton-http-api set from phase 2 (before service) to phase 8 (after service + auth). Service starts with default URL from config generate.

Notes

Linear: SMA-70

Closes SMA-70

- Unified POST /v1/elections/settings for stake-policy, tick-interval, max-factor - Unified POST /v1/ton-http-api with append flag for set/add - POST /v1/log for log settings - Added save_to_file to elections exclude/include handlers - Removed config stake-policy alias, moved vault_secret_missing to utils - CI: moved ton-http-api set from phase 2 to phase 8

…ions Entity CRUD and ton-http-api handlers signal config_changed after save_to_file so the service loop calls force_reload to rebuild wallets, pools, RPC client and restart tasks immediately.

linear · 2026-04-15T11:49:42Z

SMA-70 Centralize config management: settings mutations via REST API

Copilot

Pull request overview

Migrates multiple nodectl config “settings mutation” commands (elections, log, ton-http-api, include/exclude) from direct file edits to REST API calls, and wires REST-side structural mutations to trigger cache rebuilds so changes take effect immediately.

Changes:

Add REST mutation endpoints for elections settings, ton-http-api, and log; migrate old stake-strategy endpoint to elections settings.
Introduce config_changed notification path so structural REST mutations trigger RuntimeConfigStore::force_reload() and task restarts.
Consolidate mutation persistence by switching remaining update_with/save_to_file call sites to update_and_save.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
src/node/tests/test_run_net_py/run_singlehost_nodectl.py	Moves ton-http-api set to a phase where REST/auth is available.
src/node-control/service/src/service_main_task.rs	Adds `config_changed` Notify and `force_reload` + restart on structural REST mutations.
src/node-control/service/src/runtime_config.rs	Adds `force_reload()` helper; continues migration toward `update_and_save`.
src/node-control/service/src/http/http_server_task.rs	Replaces stake-strategy route with elections settings mutation route; updates tests and uses `update_and_save`.
src/node-control/service/src/http/config_handlers.rs	Implements REST mutation handlers for elections settings, ton-http-api, and log; emits `config_changed` for structural changes.
src/node-control/service/src/http/auth_tests.rs	Updates auth tests to target new elections settings mutation endpoint and adds `config_changed` to test state.
src/node-control/commands/src/commands/nodectl/utils.rs	Adds shared `vault_secret_missing` helper for CLI commands.
src/node-control/commands/src/commands/nodectl/service_api_cmd.rs	Updates stake policy mutation to call `/v1/elections/settings` with a mirrored request DTO.
src/node-control/commands/src/commands/nodectl/config_wallet_cmd.rs	Reuses shared vault helper; removes local duplicate.
src/node-control/commands/src/commands/nodectl/config_ton_http_api_cmd.rs	Migrates ton-http-api set/add to REST calls.
src/node-control/commands/src/commands/nodectl/config_node_cmd.rs	Reuses shared vault helper; removes local duplicate.
src/node-control/commands/src/commands/nodectl/config_log_cmd.rs	Migrates log set to REST call and renders response.
src/node-control/commands/src/commands/nodectl/config_elections_cmd.rs	Migrates elections mutations (policy/tick/max-factor/include/exclude) to REST calls.
src/node-control/commands/src/commands/nodectl/config_cmd.rs	Removes legacy stake-policy shortcut and routes ton-http-api/log/elections mutations through REST-aware commands.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-15T11:55:27Z

+                if let Err(e) = runtime_cfg.force_reload().await {
+                    tracing::error!("cache rebuild after config mutation failed: {e:#}");
+                }
+                for task in tasks.values() {
+                    let _ = task.restart().await;
+                }


In the config_changed branch, tasks are restarted even when runtime_cfg.force_reload() fails. Since update_and_save mutates only the config snapshot (not the cached wallets/pools/RPC client), a failed force_reload leaves caches inconsistent with the new config; restarting tasks in that state can cause hard-to-debug runtime errors. Consider restarting tasks only after a successful force_reload, and otherwise leaving tasks running on the previous caches (and/or reverting the config change / returning an error to the caller).

Suggested change

if let Err(e) = runtime_cfg.force_reload().await {

tracing::error!("cache rebuild after config mutation failed: {e:#}");

}

for task in tasks.values() {

let _ = task.restart().await;

}

match runtime_cfg.force_reload().await {

Ok(()) => {

for task in tasks.values() {

let _ = task.restart().await;

}

}

Err(e) => {

tracing::error!(

"cache rebuild after config mutation failed; skipping task restart: {e:#}"

);

}

}

Copilot · 2026-04-15T11:55:27Z

+            if append {
+                let existing = cfg.ton_http_api.endpoints();
+                for url in &urls {
+                    if !existing.iter().any(|e| e == url) {
+                        let entry = match &api_key {
+                            Some(key) => {
+                                EndpointEntry::WithKey { url: url.clone(), api_key: key.clone() }
+                            }
+                            None => EndpointEntry::Url(url.clone()),
+                        };
+                        cfg.ton_http_api.urls.push(entry);
+                    }


In append mode, existing is computed once before the loop, so duplicates within the incoming urls list (or duplicates added earlier in the loop) can still be pushed into cfg.ton_http_api.urls. This can bloat the stored config even though endpoints() dedupes for display. Consider tracking a mutable set of seen URLs (initialized from resolved_endpoints()/endpoints()) and inserting into it as you push new entries.

Copilot · 2026-04-15T11:55:28Z

+    let level = req
+        .level
+        .as_deref()
+        .map(|l| {
+            tracing::Level::from_str(l)
+                .map_err(|_| AppError::bad_request(format!("invalid log level: '{l}'")))
+        })
+        .transpose()?;


req.level is parsed as-is; values with leading/trailing whitespace (e.g. " info ") will be rejected even though they’re semantically valid. Consider trimming the string before Level::from_str to make the API more robust.

Copilot · 2026-04-15T11:55:28Z

+    // Pre-validate: file/all output requires a path (check against current + incoming)
+    if let Some(ref output) = req.output {
+        if matches!(output, LogOutput::File | LogOutput::All) {
+            let has_path = req.path.is_some()
+                || state.runtime_cfg.get().log.as_ref().and_then(|l| l.path.as_ref()).is_some();
+            if !has_path {
+                let mode = match output {


The "output requires a path" pre-validation treats req.path.is_some() as sufficient, but an empty string path would pass this check and later be persisted as PathBuf(""). Consider trimming/validating req.path and treating empty/whitespace-only values as unset (or returning 400).

Copilot · 2026-04-15T11:55:28Z

+/// Client-side mirror of `ElectionsSettingsUpdateRequest` in `service::http::config_handlers`.
+/// Must stay in sync with the server-side definition.
+#[derive(Clone, Default, serde::Serialize)]
+struct ElectionsSettingsRequest {
+    #[serde(skip_serializing_if = "Option::is_none")]
+    policy: Option<StakePolicy>,
    #[serde(skip_serializing_if = "Option::is_none")]
    node: Option<String>,
+    #[serde(default, skip_serializing_if = "std::ops::Not::not")]
+    reset: bool,
+    #[serde(skip_serializing_if = "Option::is_none")]
+    tick_interval: Option<u64>,
+    #[serde(skip_serializing_if = "Option::is_none")]
+    max_factor: Option<f32>,
 }


There are now multiple client-side request structs mirroring the same server DTO (ElectionsSettingsUpdateRequest) across commands (e.g. here and in config_elections_cmd.rs). This is easy to let drift over time. Consider defining a single shared request type in one module (or a common crate) and reusing it for all callers of /v1/elections/settings.

Agreed — this is real duplication. Tracking as a follow-up in v0.5.0: a refactor to extract shared REST request/response DTOs into a common module reused by both the service handlers and the CLI commands. Out of scope for this PR.

… dedupe ton-http-api, trim log inputs

…ig ton-http-api` cmd - breaking change! to use a different word from `--url` option in the config root cmd

…RL env

Keshoid added 3 commits April 15, 2026 14:33

feat(service): notify service loop to rebuild caches after REST mutat…

5a47a5c

…ions Entity CRUD and ton-http-api handlers signal config_changed after save_to_file so the service loop calls force_reload to rebuild wallets, pools, RPC client and restart tasks immediately.

fix(service): migrate remaining save_to_file callers to update_and_save

3935478

Copilot AI review requested due to automatic review settings April 15, 2026 11:49

Copilot started reviewing on behalf of Keshoid April 15, 2026 11:50 View session

Keshoid requested review from ITBear, Lapo4kaKek and mrnkslv April 15, 2026 11:51

Copilot AI reviewed Apr 15, 2026

View reviewed changes

fix(service): address copilot review: gate restart on reload success,…

47ac2a1

… dedupe ton-http-api, trim log inputs

ITBear approved these changes Apr 15, 2026

View reviewed changes

Keshoid added 3 commits April 15, 2026 16:40

feat(commands)!: rename option from --url to --endpoint for `conf…

bec3d55

…ig ton-http-api` cmd - breaking change! to use a different word from `--url` option in the config root cmd

feat(commands): update config command URL help text and add NODECTL_U…

4b8cae6

…RL env

test: fix adding endpoints in ci script

275628e

Keshoid added the run-e2e label Apr 15, 2026

Keshoid merged commit 61dfa32 into release/nodectl/v0.4.0 Apr 15, 2026
5 of 7 checks passed

Keshoid deleted the feature/sma-70-centralize-config-management-part3 branch April 15, 2026 14:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(nodectl): settings mutations via REST API#91

feat(nodectl): settings mutations via REST API#91
Keshoid merged 7 commits into
release/nodectl/v0.4.0from
feature/sma-70-centralize-config-management-part3

Keshoid commented Apr 15, 2026 •

edited

Loading

Uh oh!

linear Bot commented Apr 15, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Keshoid Apr 15, 2026

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Keshoid Apr 15, 2026

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Keshoid Apr 15, 2026

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Keshoid Apr 15, 2026

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Keshoid Apr 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Keshoid commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Breaking changes

CI script

Notes

Uh oh!

linear Bot commented Apr 15, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Keshoid Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Keshoid Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Keshoid Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Keshoid Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Keshoid Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Keshoid commented Apr 15, 2026 •

edited

Loading