Skip to content

feat[STM32][USART]: add uart error callback support#11328

Merged
Rbb666 merged 1 commit intoRT-Thread:masterfrom
wdfk-prog:stm32_usart_v2
Apr 17, 2026
Merged

feat[STM32][USART]: add uart error callback support#11328
Rbb666 merged 1 commit intoRT-Thread:masterfrom
wdfk-prog:stm32_usart_v2

Conversation

@wdfk-prog
Copy link
Copy Markdown
Contributor

@wdfk-prog wdfk-prog commented Apr 14, 2026

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

STM32 USART V2 驱动当前缺少设备级错误回调注册与上报能力,上层很难在 HAL UART 错误回调触发时感知具体错误并执行恢复逻辑。同时,RT_DEVICE_CTRL_CONFIG 在非 DMA 构建下请求 DMA 模式时没有显式返回不支持错误码,非 DMA 分支回退到 RT_DEVICE_CTRL_SET_INT 时也没有向上传递返回值,导致控制路径语义不够明确。

你的解决方案是什么 (what is your solution)

本 PR 为 STM32 USART V2 驱动新增 UART_CTRL_SET_ERROR_CALLBACK 控制命令,并在 struct stm32_uart 中增加 error_indicate 回调指针,用于注册设备级 UART 错误回调。
HAL_UART_ErrorCallback() 中,当回调已注册时调用上层错误通知接口,并在设备关闭路径中先将回调清空再执行 HAL_UART_DeInit(),避免关闭过程中继续使用旧回调。
同时补充控制路径返回值处理:当未启用 DMA 支持却请求 DMA 模式时显式返回 -RT_ENOSYS;非 DMA 分支回退到 RT_DEVICE_CTRL_SET_INT 时直接返回其处理结果。

请提供验证的bsp和config (provide the config and bsp)

  • BSP:

    • 待补充
  • .config:

    • 本补丁未新增 Kconfig 选项
    • 待补充用于验证的现有 UART 相关配置
  • action:

    • 待补充

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

add a control command to register a per-device uart error callback
invoke the callback from the HAL uart error hook and clear it before close
return -RT_ENOSYS when dma mode is requested without dma support
propagate the set-int fallback result in optmode setup to keep control return values explicit
@github-actions
Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to:stm32_usart_v2
  • 设置PR number为 \ Set the PR number to:11328
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后,提交将自动更新至 stm32_usart_v2 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the stm32_usart_v2 branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions github-actions bot added BSP: STM32 BSP related with ST/STM32 BSP labels Apr 14, 2026
@github-actions
Copy link
Copy Markdown

📌 Code Review Assignment

🏷️ Tag: bsp_stm32

Reviewers: @Liang1795 @hamburger-os @wdfk-prog

Changed Files (Click to expand)
  • bsp/stm32/libraries/HAL_Drivers/drivers/drv_usart_v2.c
  • bsp/stm32/libraries/HAL_Drivers/drivers/drv_usart_v2.h

📊 Current Review Status (Last Updated: 2026-04-14 15:40 CST)


📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@Rbb666 Rbb666 merged commit 072cb3a into RT-Thread:master Apr 17, 2026
37 checks passed
@wdfk-prog wdfk-prog deleted the stm32_usart_v2 branch April 19, 2026 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: STM32 BSP related with ST/STM32 BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants