Skip to content

[utest][pin] add pin loopback utest#11445

Open
CYFS3 wants to merge 2 commits into
RT-Thread:masterfrom
CYFS3:feat_pin_utest
Open

[utest][pin] add pin loopback utest#11445
CYFS3 wants to merge 2 commits into
RT-Thread:masterfrom
CYFS3:feat_pin_utest

Conversation

@CYFS3

@CYFS3 CYFS3 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

新增通用 pin 驱动 utest,用两个短接 GPIO 验证 RT-Thread pin API 的输入输出和中断路径,方便 BSP 上快速确认 pin 驱动基础功能。
image

同时修复 utest 框架在 testcase init/cleanup 失败时最终汇总仍显示 passed 的问题。该问题在 pin utest 配错 pin 名称时复现:init 已打印 FAILED,但汇总仍显示 PASSED 1 tests。
image
image

你的解决方案是什么 (what is your solution)

  • 在 drivers pin 下新增 components.drivers.pin.loopback 用例,并接入 utest Kconfig/SCons。
  • 支持通过 pin name 或 pin number 配置一对短接测试 pin。
  • 覆盖 rt_pin_modert_pin_writert_pin_read 的电平 loopback 验证。
  • 可选覆盖 rt_pin_attach_irqrt_pin_irq_enablert_pin_detach_irq 的 rising/falling/both-edge IRQ loopback 验证。
  • 修复 utest testcase init、testcase body 缺失、cleanup 失败时的失败计数和失败列表标记,避免最终汇总误报 passed。

请提供验证的bsp和config (provide the config and bsp)

  • BSP:

bsp/stm32/stm32f407-rt-spark

  • .config:

CONFIG_RT_USING_UTESTCASES=y
CONFIG_RT_USING_PIN=y
CONFIG_RT_UTEST_PIN=y
CONFIG_RT_UTEST_PIN_OUT_NAME="PD.7"
CONFIG_RT_UTEST_PIN_IN_NAME="PD.10"
CONFIG_RT_UTEST_PIN_IRQ=y

测试说明:短接 PD.7 和 PD.10,对应运行日志中 output pin 55、input pin 58。执行 utest_run components.drivers.pin.loopback 后,pin_loopback_levelpin_loopback_irq_risingpin_loopback_irq_fallingpin_loopback_irq_both_edges 均执行,最终 testcase passed。用户提供的终端截图显示该用例通过。

另验证了错误 pin name 配置场景,rt_pin_get() 返回 -5 时 testcase init failed;本 PR 的 utest 框架修复会将该 init failed 正确计入最终 failed 汇总,避免误报 passed。

  • action:

本地验证:

  • git diff --check HEAD~2..HEAD
  • pin utest 在 bsp/stm32/stm32f407-rt-spark 上短接 PD.7/PD.10 后运行通过,见上述截图说明。
    ]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to:feat_pin_utest
  • 设置PR number为 \ Set the PR number to:11445
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后,提交将自动更新至 feat_pin_utest 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the feat_pin_utest branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

📌 Code Review Assignment

🏷️ Tag: components

Reviewers: @Maihuanyi

Changed Files (Click to expand)
  • components/drivers/pin/SConscript
  • components/drivers/pin/utest/Kconfig
  • components/drivers/pin/utest/SConscript
  • components/drivers/pin/utest/pin_loopback.c
  • components/utilities/utest/utest.c

📊 Current Review Status (Last Updated: 2026-06-08 11:35 CST)


📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@CYFS3 CYFS3 marked this pull request as ready for review June 8, 2026 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant