Skip to content

[components][pthreads] fix cond wait scheduling#11533

Merged
Rbb666 merged 1 commit into
RT-Thread:masterfrom
Old-Ding:codex/fix-pthread-cond-schedule
Jul 1, 2026
Merged

[components][pthreads] fix cond wait scheduling#11533
Rbb666 merged 1 commit into
RT-Thread:masterfrom
Old-Ding:codex/fix-pthread-cond-schedule

Conversation

@Old-Ding

Copy link
Copy Markdown
Contributor

What changed

Add the missing scheduler invocation in _pthread_cond_timedwait() after the current thread has been suspended, the pthread mutex has been released, and the critical section has been exited.

Root cause

The wait path put the current thread onto the condition semaphore suspend list, but only called rt_exit_critical() before reading thread->error and re-locking the mutex. Without rt_schedule(), the suspended thread could continue running instead of yielding to the scheduler, which breaks pthread condition wait users such as pthread read/write locks.

Scope

This keeps the fix in the condition variable wait implementation, which is the layer that directly suspends the thread. It does not add duplicate scheduling behavior in pthread rwlock callers.

Closes #11532

Validation

  • git diff --check
  • gh search prs 'pthread_cond_timedwait rt_schedule' --repo RT-Thread/rt-thread --state open --limit 20 --json number,title,author,url,isDraft returned no duplicate open PRs.
  • Tried python -m SCons -n on pthread-enabled BSPs (bsp/mipssim, bsp/microchip/samd51-adafruit-metro-m4), but local cross-toolchain paths are not installed, so BSP build validation could not complete locally.

@github-actions

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to:codex/fix-pthread-cond-schedule
  • 设置PR number为 \ Set the PR number to:11533
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后,提交将自动更新至 codex/fix-pthread-cond-schedule 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the codex/fix-pthread-cond-schedule branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions

Copy link
Copy Markdown

📌 Code Review Assignment

🏷️ Tag: components

Reviewers: @Maihuanyi

Changed Files (Click to expand)
  • components/libc/posix/pthreads/pthread_cond.c

🏷️ Tag: components_libc

Reviewers: @GorrayLi @mysterywolf

Changed Files (Click to expand)
  • components/libc/posix/pthreads/pthread_cond.c

📊 Current Review Status (Last Updated: 2026-06-30 09:54 CST)


📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@Old-Ding Old-Ding marked this pull request as ready for review June 30, 2026 02:05
@Old-Ding Old-Ding requested a review from mysterywolf as a code owner June 30, 2026 02:05
@Rbb666 Rbb666 merged commit 0c25ffa into RT-Thread:master Jul 1, 2026
104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] 5.2.x pthread 读写锁异常,_pthread_cond_timedwait升级时遗漏了rt_schedule操作

2 participants