[WIP][🏅BSP][stm32] 添加野火stm32f767开发板bsp #2058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armink
reviewed
Dec 11, 2018
Member
armink
left a comment
armink
left a comment
There was a problem hiding this comment.
非常棒，这么快就搞出来了一个新的 BSP，还是一个全新的 F7 系列，多谢你的贡献。
另外， HAL/CMSIS/DSP_Lib 不知道在你这里用到没有，如果没有就先移除吧，这个文件夹占用的体积太大了；
更多内容， @SummerGGift 负责 review
balanceTWK
reviewed
Dec 11, 2018
| #if defined(SOC_SERIES_STM32F1) || defined(SOC_SERIES_STM32L4) || defined(SOC_SERIES_STM32F4) | ||
| #define UART_INSTANCE_CLEAR_FUNCTION __HAL_UART_CLEAR_FLAG | ||
| #elif defined(SOC_SERIES_STM32F7) | ||
| #define UART_INSTANCE_CLEAR_FUNCTION __HAL_UART_CLEAR_IT |
补全了必要的hal库，stm32f767-fire的sram大小更正为512
armink
reviewed
Dec 12, 2018
| #ifdef RT_USING_SPI | ||
|
|
||
| #if defined(BSP_USING_SPI1) || defined(BSP_USING_SPI2) || defined(BSP_USING_SPI3) || defined(BSP_USING_SPI4) || defined(BSP_USING_SPI5) | ||
| #define BSP_USING_SPI1 |
Member
There was a problem hiding this comment.
上面两个 #define 好像不应该有，是在 menuconfig 里选的
Contributor
Author
There was a problem hiding this comment.
上面两个 #define 好像不应该有，是在 menuconfig 里选的
之前测试的时候忘记删除了
| #define RT_USING_DEVICE_IPC | ||
| #define RT_PIPE_BUFSZ 512 | ||
| #define RT_USING_SERIAL | ||
| #define RT_SERIAL_USING_DMA |
Member
There was a problem hiding this comment.
这个 DMA 关掉吧，默认提交的工程应该是驱动功能比较小的配置，参考其他 BSP。
Contributor
Author
There was a problem hiding this comment.
这个DMA在我这无法用menuconfig关闭，只能用menuconfig开启，得手动删除，不知道什么原因
Member
There was a problem hiding this comment.
哦，我知道了，不是你的问题，是最近在设备框架新增了 DMA 模式开关，那是可以保留
| { | ||
| rt_pin_mode(LED0_PIN, PIN_MODE_OUTPUT); | ||
| rt_pin_mode(LED1_PIN, PIN_MODE_OUTPUT); | ||
| // rt_pin_mode(LED1_PIN, PIN_MODE_OUTPUT); |
armink
reviewed
Dec 14, 2018
| config BSP_USING_QSPI_FLASH | ||
| bool "Enable QSPI FLASH (W25Q128 spi5)" | ||
| select BSP_USING_SPI5 | ||
| bool "Enable QSPI FLASH" |
Member
There was a problem hiding this comment.
Enable QSPI FLASH (W25Q128 qspi1)
BernardXiong
changed the title
SummerGift
approved these changes
Dec 20, 2018
Member
SummerGift
left a comment
SummerGift
left a comment
There was a problem hiding this comment.
该 BSP 可以合并了，其他细节内容可以合并后续修改。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.