Skip to content

Conversation

@ylz0923
Copy link
Contributor

@ylz0923 ylz0923 commented Jan 16, 2019

拉取/合并请求描述:(PR description)

[
优化void rt_hw_us_delay(rt_uint32_t us)
]

以下的内容请在提交PR后,一项项进行check,没问题后逐条在页面上打钩。
The following contents should be checked item by item after submitted PR, and ticked on the browser one by one after no problem.

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other style
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 本拉取/合并请求代码是高质量的 Code in this PR is of high quality

优化void rt_hw_us_delay(rt_uint32_t us)
@CLAassistant
Copy link

CLAassistant commented Jan 16, 2019

CLA assistant check
All committers have signed the CLA.

@BernardXiong BernardXiong requested a review from lymzzyh January 16, 2019 09:35
@BernardXiong BernardXiong merged commit b3c4f3b into RT-Thread:master Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants