Skip to content

Conversation

@SummerGift
Copy link
Member

@SummerGift SummerGift commented May 8, 2019

拉取/合并请求描述:(PR description)

[
【修改】 网卡驱动的初始化应当在 lwip 初始化之后以及应用调用网络接口之前,因此修改初始化等级为 device 是比较合适的。

现在的情况是,网卡在 app 等级来初始化,一些应用例如 ADB 也在 app 等级自动初始化,网络驱动和应用的初始化先后顺序不能确定。

如果应用在初始化时网络驱动还没有调用 lwip 的接口进行网卡 up ,那么创建 socket 时就会出错,因此需要提前网卡驱动的初始化顺序。

已经在正点原子 f767 开发板以及 qemu 上做过测试。
]

以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use web browser to visit PR, and check items one by one, and ticked them if no problem.

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other style
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 本拉取/合并请求代码是高质量的 Code in this PR is of high quality

Copy link
Contributor

@rtthread-bot rtthread-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoTest Result

Rate: 62.50%
Passed: 10/16

点击查看详情

@BernardXiong
Copy link
Member

测试用例很多失败了

@SummerGift
Copy link
Member Author

SummerGift commented May 9, 2019

这个要等后台修一下重新跑一次,后台发送的测试命令出错了。

@SummerGift SummerGift closed this May 9, 2019
@SummerGift SummerGift reopened this May 9, 2019
Copy link
Contributor

@rtthread-bot rtthread-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoTest Result

Rate: 81.25%
Passed: 13/16

点击查看详情

Copy link
Contributor

@rtthread-bot rtthread-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoTest Result

Rate: 100.00%
Passed: 16/16

点击查看详情

@SummerGift
Copy link
Member Author

@BernardXiong
@Lawlieta 提交的 #2668 与网卡的修复之后,本 PR 的测试用例已经全部通过了。

@BernardXiong BernardXiong merged commit 3d04e46 into RT-Thread:master May 13, 2019
@SummerGift SummerGift deleted the master_lab branch October 30, 2019 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants