-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[STM32/drv_pwm.c]fixed PWM timer init. #3337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rtthread-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Hello, 新年好! 这里进行这样修改的原因是什么呢? |
看上面贴的ISSUES 3333,里面有描述 |
根据 HAL 驱动的描述,这里应该只是选择一种方式进行初始化,而不是使用两种,感谢提交。 |
|
嗯,我看到了,根据 HAL 库中的描述,重新初始化 PWM 功能,应当先调用 deinit() 函数,这里先配置成 base 模式后没有进行 deinit,又直接配置成 PWM 模式应该是存在初始化错误问题的。 感谢指出错误。 |
拉取/合并请求描述:(PR description)
[
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up