-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[bsp/stm32] add the bsp of stm32l496zg-nucleo board #3452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SummerGift
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 114 in a7bcf90
| - RTT_BSP='stm32/stm32l496-ali-developer' RTT_TOOL_CHAIN='sourcery-arm' |
请参照上述代码,在 CI 流程中添加该 BSP。
| * | ||
| * Change Logs: | ||
| * Date Author Notes | ||
| * 2020-03-14 super_mcu first version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
代码对齐
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
感谢你的提交,没有发现太多问题,请在修改这些格式问题后根据参考代码添加 CI 测试。
|
终于搞定了。 |
|
@summerlife 这个对了吗?不太确定是否正确。不太会修改之后提交。文档我觉得可以添加一下。自己摸索,不知道对不对。合入的时候帮忙稍微check一下吧。 |
SummerGift
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嗯,应该没问题了,感谢你提交,赞!
拉取/合并请求描述:(PR description)
[add the bsp of stm32l496zg-nucleo board
提交一个stm32板子;解决L496ZG-nucleo板子bsp还没有的问题;解决方法添加STM32 bsp
已经在stm32l496zg-nucleo板子上进行了测试
]
以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use web browser to visit PR, and check items one by one, and ticked them if no problem.
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up