Skip to content

Conversation

@supperthomas
Copy link
Member

拉取/合并请求描述:(PR description)

[add the bsp of stm32l496zg-nucleo board
提交一个stm32板子;解决L496ZG-nucleo板子bsp还没有的问题;解决方法添加STM32 bsp
已经在stm32l496zg-nucleo板子上进行了测试
]

以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use web browser to visit PR, and check items one by one, and ticked them if no problem.

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other style
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 本拉取/合并请求代码是高质量的 Code in this PR is of high quality

@CLAassistant
Copy link

CLAassistant commented Mar 14, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@SummerGift SummerGift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- RTT_BSP='stm32/stm32l496-ali-developer' RTT_TOOL_CHAIN='sourcery-arm'

请参照上述代码,在 CI 流程中添加该 BSP。

*
* Change Logs:
* Date Author Notes
* 2020-03-14 super_mcu first version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代码对齐

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢你的提交,没有发现太多问题,请在修改这些格式问题后根据参考代码添加 CI 测试。

@supperthomas
Copy link
Member Author

终于搞定了。

@supperthomas
Copy link
Member Author

@summerlife 这个对了吗?不太确定是否正确。不太会修改之后提交。文档我觉得可以添加一下。自己摸索,不知道对不对。合入的时候帮忙稍微check一下吧。

Copy link
Member

@SummerGift SummerGift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯,应该没问题了,感谢你提交,赞!

@BernardXiong BernardXiong merged commit 9388434 into RT-Thread:master Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants