更新mini2440 bsp包: #3520
Merged
更新mini2440 bsp包: #3520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1、加入Kconfig以支持图形化菜单配置 2、编译脚本中添加动态模块编译参数 3、开启自动初始化机制支持 4、重构串口驱动以解决开启posix支持后终端无响应问题 5、解决dm9000网卡驱动link up问题 6、添加mnt.c文件用来挂载文件系统
bsp/mini2440/drivers/board.c
Outdated
|
|
||
| } | ||
|
|
||
| #ifdef RT_USING_MODULE |
bsp/mini2440/drivers/sdcard.c
Outdated
| rt_kprintf("allocate partition sector buffer failed\n"); | ||
|
|
||
| return; | ||
| return RT_ERROR; |
Contributor
Author
There was a problem hiding this comment.
错误时，请返回负数
您好，感谢您的检视。请问我在源码中没有找到负数错误码的宏定义，是直接返回-1吗？
Member
There was a problem hiding this comment.
这个是需要返回 -RT_ERROR; 类似的负数的error。
Contributor
Author
There was a problem hiding this comment.
已按照建议修改了返回值。请问下，pr当前状态为changes request。这种状态下我该如何处理，才能让pr的流程继续往下走。第一次发起pr，不太明白,谢谢。^ ^
bsp/mini2440/applications/mnt.c
Outdated
| int mnt_init(void) | ||
| { | ||
|
|
||
| if(dfs_mount(RT_NULL, "/", "ram", 0, dfs_ramfs_create(rt_malloc(1024),1024)) == 0) |
Member
There was a problem hiding this comment.
这里就直接创建出这么大的ramdisk了，貌似不太好吧，可以使用sdcard做为root吗？或者弄个romfs来做为根。
bsp/mini2440/drivers/SConscript
Outdated
|
|
||
| if GetDepend('RT_USING_RTGUI'): | ||
| src += ['touch.c', 'key.c', 'calibration.c'] | ||
| src += ['touch.c', 'key.c'] |
Member
There was a problem hiding this comment.
RT_USING_RTGUI是否还有？现在只有GUI Engine的软件包了，是PKG_USING_RTGUI吧
bsp/mini2440/drivers/SConscript
Outdated
| src += ['touch.c', 'key.c', 'calibration.c'] | ||
| src += ['touch.c', 'key.c'] | ||
|
|
||
| if GetDepend('RT_USING_FTK'): |
2. Modify the return code to -1 when failed 3. Change the mounting filesystem from ramfs to sdcard 4. Replace RT_USING_RTGUI with PKG_USING_GUIENGINE and remove RT_USING_FTK
qzhang1535
commented
Apr 13, 2020
Contributor
Author
qzhang1535
left a comment
qzhang1535
left a comment
There was a problem hiding this comment.
针对文件系统挂载，返回错误码作出修改，删除无用的函数
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述：(PR description)
[
目前mini2440的bsp包代码比较旧，无法使用rt-thread新的功能和特性(自动化初始机制、posix接口等)。故对bsp里部分代码做些修改以适配新的功能。具体修改如下:
1、加入Kconfig以支持图形化菜单配置
2、编译脚本中添加动态模块编译参数
3、开启自动初始化机制支持
4、重构串口驱动以解决开启posix支持后终端无响应问题
5、解决dm9000网卡驱动link up问题
6、添加mnt.c文件用来挂载文件系统
]
以下的内容不应该在提交PR时的message修改，修改下述message，PR会被直接关闭。请在提交PR后，浏览器查看PR并对以下检查项逐项check，没问题后逐条在页面上打钩。
The following content must not be changed in submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use web browser to visit PR, and check items one by one, and ticked them if no problem.
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up