Update bsp for mini2440 #3532
Merged
Update bsp for mini2440 #3532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Add choice menu for lcd configure 3. Remove origin sdcard driver and add new mmc driver that use kernel mmc stack for s3c2440
bsp/mini2440/applications/main.c
Outdated
| device = rt_device_find("lcd"); | ||
| if (device) | ||
| { | ||
| rtgui_graphic_set_device(device); |
bsp/mini2440/applications/mnt.c
Outdated
| int mnt_init(void) | ||
| { | ||
| if (dfs_mount("sd0", "/", "elm", 0, 0) == 0) | ||
| rt_uint32_t tryCnt = 5; |
Member
There was a problem hiding this comment.
Please take care of indention too.
bsp/mini2440/drivers/lcd_t43.c
Outdated
| * | ||
| * The license and distribution terms for this file may be | ||
| * found in the file LICENSE in this distribution or at | ||
| * http://www.rt-thread.org/license/LICENSE |
Member
There was a problem hiding this comment.
请注意文件头版权信息，新的代码请都以Apache License v2.0贡献您的代码
bsp/mini2440/drivers/lcd_t43.c
Outdated
|
|
||
| static void lcd_envid_on_off(int onoff) | ||
| { | ||
| if(onoff==1) |
Member
There was a problem hiding this comment.
Please take care of indention too.
BernardXiong
requested changes
Apr 15, 2020
Member
BernardXiong
left a comment
BernardXiong
left a comment
There was a problem hiding this comment.
Please take care of indention.
2. Modify the license head
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述：(PR description)
[
1. Add 4.3 inch lcd(480x272) support for mini2440
2. Add choice menu for lcd configure
3. Remove origin sdcard driver and add new mmc driver that use kernel mmc stack for s3c2440
]
以下的内容不应该在提交PR时的message修改，修改下述message，PR会被直接关闭。请在提交PR后，浏览器查看PR并对以下检查项逐项check，没问题后逐条在页面上打钩。
The following content must not be changed in submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use web browser to visit PR, and check items one by one, and ticked them if no problem.
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up