Skip to content

Conversation

@liukangcc
Copy link
Member

@liukangcc liukangcc commented Sep 23, 2020

拉取/合并请求描述:(PR description)

[
添加 OpenAMP, 修改部分驱动代码;已在 STM32MP1-DK1 开发板上测试完成。
]

以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use web browser to visit PR, and check items one by one, and ticked them if no problem.

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other style
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 本拉取/合并请求代码是高质量的 Code in this PR is of high quality

@rtthread-bot
Copy link
Contributor

感谢提交 Pull Requests !
在我们查看您的 Pull Requests 之前,您需要签署《贡献者许可协议(CLA)》。
请按照 https://www.rt-thread.org/cla/ 页面提示步骤操作,完成 CLA 签署。之后新增评论 /check-cla,我们将再次检查协议签署情况。

  • 如果您已签署 CLA 且仍然出现此提示,请在 Github 账号个人页面 https://github.com/settings/emails 确认已绑定邮箱并验证,同时与签署页面填写的邮箱一致。
  • 若您完成以上步骤后,依然显示 CLA 未签署信息,请发邮件联系我们,邮箱地址:contact@rt-thread.org

Thanks for your pull request.
Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
Please follow instructions at https://www.rt-thread.org/cla/ to sign the CLA.
It may take a couple minutes for the CLA signature to be fully registered;
after that, please reply here with a new comment /check-cla and we'll verify.

  • If you've already signed a CLA, it's possible we don't have your Github username or you're using a different email address.
    Check your existing CLA data and verify that your email at https://github.com/settings/emails.
  • If you have done the above and are still having issues with the CLA being reported as unsigned,
    send a message to the backup e-mail support address at: contact@rt-thread.org

@liukangcc
Copy link
Member Author

/check-cla

1 similar comment
@liukangcc
Copy link
Member Author

/check-cla

@rtthread-bot
Copy link
Contributor

感谢提交 Pull Requests !
在我们查看您的 Pull Requests 之前,您需要签署《贡献者许可协议(CLA)》。
请按照 https://www.rt-thread.org/cla/ 页面提示步骤操作,完成 CLA 签署。之后新增评论 /check-cla,我们将再次检查协议签署情况。

  • 如果您已签署 CLA 且仍然出现此提示,请在 Github 账号个人页面 https://github.com/settings/emails 确认已绑定邮箱并验证,同时与签署页面填写的邮箱一致。
  • 若您完成以上步骤后,依然显示 CLA 未签署信息,请发邮件联系我们,邮箱地址:contact@rt-thread.org

Thanks for your pull request.
Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
Please follow instructions at https://www.rt-thread.org/cla/ to sign the CLA.
It may take a couple minutes for the CLA signature to be fully registered;
after that, please reply here with a new comment /check-cla and we'll verify.

  • If you've already signed a CLA, it's possible we don't have your Github username or you're using a different email address.
    Check your existing CLA data and verify that your email at https://github.com/settings/emails.
  • If you have done the above and are still having issues with the CLA being reported as unsigned,
    send a message to the backup e-mail support address at: contact@rt-thread.org

@liukangcc
Copy link
Member Author

/check-cla

@rtthread-bot
Copy link
Contributor

感谢提交 Pull Requests!您已成功签署《贡献者许可协议(CLA)》。:wave:


Thanks for your pull request. you've already signed RT-Thread CLA successfully. 👋

@BernardXiong BernardXiong merged commit cc8de79 into RT-Thread:master Sep 24, 2020
@liukangcc liukangcc deleted the stm32mp157a-dk1 branch November 21, 2020 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants