Skip to content

Conversation

@mysterywolf
Copy link
Member

@mysterywolf mysterywolf commented Feb 7, 2021

拉取/合并请求描述:(PR description)

[

  1. add settimeofday()
  2. add stime()
  3. add ctime_r()
  4. add difftime()
  5. re-implement ctime()
  6. fixed gettimeofday()
  7. fixed request issue libc中实现的gettimeofday在没rtc设备时不用assert只能算io错误 #3976
  8. fix bug ctime()函数调用出错 #3183 - align days[] and months[] to 4 bytes

involved #3938
已经在潘多拉测试通过,Keil GCC IAR8.40.1 编译通过
时区问题由后续pr解决
]

以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 本拉取/合并请求代码是高质量的 Code in this PR is of high quality

rt_device_t device;

/* read timestamp from RTC device. */
if (device != RT_NULL)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这句话的作用,是为了避免每次都要遍历一次设备链表,这里为什么要去掉呢?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已恢复

@balanceTWK
Copy link
Member

[libc][time] 的修改,需要在多个编译工具链下测试通过才行。

@mysterywolf mysterywolf changed the title [libc][time]fixed gettimeofday() time() ; add settimeofday() stime() [libc][time]fixed gettimeofday(); add settimeofday() stime() Feb 8, 2021
@mysterywolf
Copy link
Member Author

[libc][time] 的修改,需要在多个编译工具链下测试通过才行。

Keil GCC IAR8.40.1 编译通过

@mysterywolf mysterywolf changed the title [libc][time]fixed gettimeofday(); add settimeofday() stime() [libc][time] 修复bug;增加time函数 Feb 10, 2021
@mysterywolf mysterywolf requested review from BernardXiong and removed request for Guozhanxin February 10, 2021 19:05
@mysterywolf mysterywolf changed the title [libc][time] 修复bug;增加time函数 [libc][time] 修复多处bug;增加time相关函数 Feb 11, 2021
@mysterywolf
Copy link
Member Author

mysterywolf commented Feb 11, 2021

在IAR KEIL GCC编译通过
潘多拉测试通过
微信截图_20210211134749
微信截图_20210211134738
微信图片_20210211135010

@BernardXiong BernardXiong merged commit a4dd106 into RT-Thread:master Feb 11, 2021
@mysterywolf mysterywolf deleted the gettimeofday branch February 11, 2021 15:46
@tongwenfei
Copy link
Contributor

@tongwenfei 你好 可否也帮忙测试一下这个文件里的其他函数是否有冲突 IAR这个玩意很头疼,不同的版本有的报错有的不报错 我用STM32版本就不会报错

其他函数没有报错

@tongwenfei
Copy link
Contributor

@tongwenfei 我的IAR是8.40版本的 你的版本号是多少?

IAR @9.10.1

@mysterywolf
Copy link
Member Author

已经做出修改#4422 IAR这个玩意是真的讨厌,各个版本的策略都不一致

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants