修复 ringblk_buf 在不使用动态内存时报错的问题以及 AT 组件优化 #4998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangxistu
reviewed
Sep 2, 2021
components/net/at/src/at_client.c
Outdated
| if (read_idx < size) | ||
| rt_sem_control(client->rx_notice, RT_IPC_CMD_RESET, RT_NULL); | ||
|
|
||
| rt_size_t read_len = rt_device_read(client->device, 0, buf + len, size); |
Member
There was a problem hiding this comment.
果然改成多字节的读取了吗？这样的话，确实需要在独取前先清空一下 rx_notice.
这里的逻辑是，进来先读取一个空的数据，然后等待 rx_notice 信号；
先等待 notice 再读取，然后再等待 rx_notice 会不会好一点？字符设备和高优先级的 at_client 不明显，块设备和低优先级的 at_client 操作一次的机会还是蛮珍贵的。
|
|
||
| rt_mutex_take(client->lock, RT_WAITING_FOREVER); | ||
| client->resp = resp; | ||
| rt_sem_control(client->resp_notice, RT_IPC_CMD_RESET, RT_NULL); |
Member
There was a problem hiding this comment.
感觉这里蛮好的，一劳永逸，将来逐行分析数据时采用 rt_device_read，这里就不用改了。
xiangxistu
approved these changes
Sep 2, 2021
loogg
changed the title
Guozhanxin
approved these changes
Sep 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述：(PR description)
[
]
以下的内容不应该在提交PR时的message修改，修改下述message，PR会被直接关闭。请在提交PR后，浏览器查看PR并对以下检查项逐项check，没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up