[bsp] stm32/stm32f407-atk-explorer add LLVM for Arm support.#5414
Closed
Guozhanxin wants to merge 1 commit intoRT-Thread:masterfrom
Closed
[bsp] stm32/stm32f407-atk-explorer add LLVM for Arm support.#5414Guozhanxin wants to merge 1 commit intoRT-Thread:masterfrom
Guozhanxin wants to merge 1 commit intoRT-Thread:masterfrom
Conversation
Member
Author
|
满老师，你试一试，文件系统、网络都是好用的。 |
mysterywolf
requested changes
Dec 22, 2021
Comment on lines
11
to
12
|
|
||
| if rtconfig.PLATFORM == 'gcc' and ('mips' in rtconfig.PREFIX): # identify mips gcc tool chain | ||
| if (rtconfig.PLATFORM == 'gcc' and ('mips' in rtconfig.PREFIX)) or rtconfig.PLATFORM == 'clang': # identify mips gcc tool chain | ||
| try: |
| @@ -15,6 +15,10 @@ | |||
| #include <sys/types.h> | |||
| #include <sys/time.h> | |||
|
|
|||
mysterywolf
requested changes
Dec 22, 2021
| startup_path_prefix = SDK_LIB | ||
|
|
||
| if rtconfig.CROSS_TOOL == 'gcc': | ||
| if rtconfig.CROSS_TOOL == 'gcc' or rtconfig.CROSS_TOOL == 'clang': |
Member
There was a problem hiding this comment.
clang可否有更好的名字，clang和armclang太相近了，很容易被人误解
mysterywolf
added
discussion
Member
Contributor
|
env 工具链中，携带了 LLVM 没？ |
Member
Author
目前，windows版本的工具链好像还有点问题 |
Closed
Member
|
#5551 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述：(PR description)
[
已在正点原子探索者开发板测试完成。
]
以下的内容不应该在提交PR时的message修改，修改下述message，PR会被直接关闭。请在提交PR后，浏览器查看PR并对以下检查项逐项check，没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up