Skip to content

Conversation

@ComerLater
Copy link
Contributor

@ComerLater ComerLater commented Jun 27, 2024

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

目前通过pip安装env工具链的时候会自动安装kconfiglib,因此tools/kconfiglib可以删除了

你的解决方案是什么 (what is your solution)

删除tools/kconfiglib文件夹,同步修改tools/building.py中,将tools/kconfiglib从sys.path移除

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@ComerLater
Copy link
Contributor Author

在env仓库更新了install_xxx脚本,增加了kconfiglib软件包的安装,这样ci运行的时候不会找不到kconfiglib了

@ComerLater
Copy link
Contributor Author

pkgs-test的ci中添加了安装kconfiglib库,RT-Thread/pkgs-test#33

@mysterywolf mysterywolf reopened this Jun 30, 2024
@mysterywolf mysterywolf merged commit c09d7e1 into RT-Thread:master Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants