Skip to content

Conversation

@flyingcys
Copy link
Contributor

@flyingcys flyingcys commented Nov 10, 2024

fix milkv-duos-sd cann't startup big-core kernel

milkv-duos-sd use cv1813h folder store ld file

Signed-off-by: flyingcys flyingcys@163.com

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

修复milkv-duos-sd 大核无法正常启动

你的解决方案是什么 (what is your solution)

将milkv-duo-sd相关链接文件单独存在在 cv1813h目录下,并取消预编译自动copy功能。

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
    cvitek/c906_little
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@github-actions github-actions bot added BSP BSP: Cvitek BSP related with cvitek labels Nov 10, 2024
milkv-duos-sd use cv1813h folder store ld file
Signed-off-by: flyingcys <flyingcys@163.com>
@flyingcys flyingcys changed the title fix milkv-duos-sd cann't startup big-core kernel [bsp/cvitek]fix milkv-duos-sd cann't startup big-core kernel Nov 12, 2024
@flyingcys flyingcys changed the title [bsp/cvitek]fix milkv-duos-sd cann't startup big-core kernel [bsp][cvitek]fix milkv-duos-sd cann't startup big-core kernel Nov 12, 2024
@mysterywolf mysterywolf requested a review from unicornx November 12, 2024 23:20
@unicornx unicornx removed the BSP label Nov 14, 2024
@unicornx
Copy link
Contributor

unicornx commented Nov 14, 2024

bsp/cvitek/combine-fip.sh 的修改 “取消预编译自动copy功能” 这个改动应该和这个 pr 的主题没有关系吧?

感觉就是原来代码中一段无效的逻辑,对所有的 duo 都是无效的,不仅仅是对 duo-S。

能否拿出来单独 pr,或者作为一个单独的 commit。这样以后看起来清晰一点。

其他没有问题。

Copy link
Contributor

@unicornx unicornx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

见 comments

@unicornx unicornx added the BSP label Nov 14, 2024
@unicornx unicornx self-requested a review November 14, 2024 06:39
@unicornx
Copy link
Contributor

算了 , approve 了吧,上面的问题希望下次注意

@unicornx
Copy link
Contributor

有个额外的问题,我看你的改动是影响的小核的链接脚本,为何标题上写的是大核跑不起来?

@BernardXiong BernardXiong merged commit 0d9185b into RT-Thread:master Nov 15, 2024
45 checks passed
GuEe-GUI pushed a commit to GuEe-GUI/rt-thread that referenced this pull request Nov 20, 2024
…ead#9633)

fix milkv-duos-sd cann't startup big-core kernel
milkv-duos-sd use cv1813h folder store ld file
Signed-off-by: flyingcys <flyingcys@163.com>
@flyingcys flyingcys deleted the fix-c906-little branch December 22, 2024 02:31
yixinghua121 pushed a commit to yixinghua121/rt-thread that referenced this pull request Mar 13, 2025
…ead#9633)

fix milkv-duos-sd cann't startup big-core kernel
milkv-duos-sd use cv1813h folder store ld file
Signed-off-by: flyingcys <flyingcys@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: Cvitek BSP related with cvitek BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants