Skip to content

[HUST CSE] Fix: possible absence of va_end after va_start#21

Merged
BernardXiong merged 1 commit intoRT-Thread:mainfrom
PeterKeyboard:main
Apr 26, 2023
Merged

[HUST CSE] Fix: possible absence of va_end after va_start#21
BernardXiong merged 1 commit intoRT-Thread:mainfrom
PeterKeyboard:main

Conversation

@PeterKeyboard
Copy link
Copy Markdown
Contributor

@PeterKeyboard PeterKeyboard commented Apr 23, 2023

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

代码中以函数va_start实现相关功能,但在一些特殊的判断条件下,代码不会调用与之对应的va_end函数,存在潜在的安全隐患。

你的解决方案是什么 (what is your solution)

在对应的判断条件下增加va_end函数,确保va_start与va_end成对出现。

在什么测试环境下测试通过 (what is the test environment)

ALL

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@PeterKeyboard PeterKeyboard marked this pull request as ready for review April 23, 2023 15:14
@BernardXiong BernardXiong merged commit 8878bc0 into RT-Thread:main Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants