[HUST CSE] Fix: possible absence of va_end after va_start#21
Merged
BernardXiong merged 1 commit intoRT-Thread:mainfrom Apr 26, 2023
Merged
[HUST CSE] Fix: possible absence of va_end after va_start#21BernardXiong merged 1 commit intoRT-Thread:mainfrom
BernardXiong merged 1 commit intoRT-Thread:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
代码中以函数va_start实现相关功能,但在一些特殊的判断条件下,代码不会调用与之对应的va_end函数,存在潜在的安全隐患。
你的解决方案是什么 (what is your solution)
在对应的判断条件下增加va_end函数,确保va_start与va_end成对出现。
在什么测试环境下测试通过 (what is the test environment)
ALL
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up