Fix wrong file names in itk_python_add_test#82
Open
acoussat wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
CI fails with the error I'm a bit confused as it does not seem related to the current PR, and I cannot reproduce it on my machine. @axel-grc any idea? |
Collaborator
Should be fixed by #83 indeed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced by #80.
I think this mistake went unnoticed because these two tests are never ran by the CI. As far as I remember, either we run
ctestwithITK_WRAP_PYTHON=OFFor we runpytestwithITK_WRAP_PYTHON=ON, but we never runctestwithITK_WRAP_PYTHON=ON. Is there a similar issue in RTK, which also usesitk_python_add_test? @axel-grc