Fix worker deadlock, add CloudWatch logging, restore home page endpoints (debug endpoints still removed) #87#88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uWSGI workers were deadlocking permanently. thunder-lock serializes
accept()withflock(), and when a worker dies while holding the lock, every other worker freezes forever. Removedthunder-lockentirely. Also raisedmax-requestsfrom 100 to 10000 because 100 was causing constant worker recycling (each one forks a 90 GB process), and addedmax-requests-delta=2000so workers don't all recycle at the same time.nginx and uWSGI logs were only going to files inside the container. On ITRB Kubernetes, kubectl logs and CloudWatch couldn't see them. Switched nginx to log to stdout/stderr directly. Added tail -F in start.sh to mirror the uWSGI log file to stderr. Also added ploverdb.log to logrotate (it was missing and would grow forever).