Skip to content

Issue 2770 - no more downloading databases at flask server start-up or pytest run time#2776

Merged
saramsey merged 2 commits into
masterfrom
issue-2770
May 18, 2026
Merged

Issue 2770 - no more downloading databases at flask server start-up or pytest run time#2776
saramsey merged 2 commits into
masterfrom
issue-2770

Conversation

@saramsey
Copy link
Copy Markdown
Member

@saramsey saramsey commented May 18, 2026

No description provided.

@saramsey saramsey requested a review from edeutsch May 18, 2026 18:29
@saramsey saramsey mentioned this pull request May 18, 2026
Closed
@saramsey
Copy link
Copy Markdown
Member Author

saramsey commented May 18, 2026 •
edited
Loading

Testing and code review status:

  • pytests look good on my MBP and on arax.ncats.io/beta
  • Flask application tested on my MBP and on arax.ncats.io/beta
  • Claude review of code edits looked clean

@saramsey
Copy link
Copy Markdown
Member Author

saramsey commented May 18, 2026 •
edited
Loading

Note, this PR eliminates the two pytest options --withdatabases and --nodatabases. I decided I could see no use-case where we want the pytest suite downloading an ARAX database file, which can be like 34 GiB in size (our standard deployment process should be to run the database manager via the CLI on arax.ncats.io and on cicd.rtx.ai).

@saramsey saramsey merged commit 8df2a03 into master May 18, 2026
4 checks passed
@saramsey saramsey deleted the issue-2770 branch May 18, 2026 23:50
@saramsey
Copy link
Copy Markdown
Member Author

saramsey commented May 18, 2026

Thanks for the review, @edeutsch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edeutsch edeutsch edeutsch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@saramsey @edeutsch