Skip to content

Conversation

@RafaelGodoyEbert
Copy link
Contributor

Pull request checklist

  • The PR has a proper title. Use Semantic Commit Messages. (No more branch-name title please)
  • Make sure you are requesting the right branch: dev.
  • Make sure this is ready to be merged into the relevant branch. Please don't create a PR and let it hang for a few days.
  • Ensure all tests are passing.
  • Ensure linting is passing.

PR type

Brazilian Portuguese language

Description

Added the Brazilian Portuguese language to the project.

Screenshot

image

Added the Brazilian Portuguese language to the project.
Copy link
Member

@Tps-F Tps-F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blaisewf
Copy link
Contributor

image
The translation has unnecessary things in addition to spam.

image

Copy link
Member

@Tps-F Tps-F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove unnecessary lines

@Tps-F
Copy link
Member

Tps-F commented Jan 15, 2024

@blaise-tk thank you for your review
I lose that

Removed external links to approve the request.
@RafaelGodoyEbert
Copy link
Contributor Author

Ok, my bad.

The ones with hearts were from EasyGUI, I deleted it completely.
image

The links to my channel and AI HUB Brasil (where you can find voice models in my language) were already there when I made the request, I sent a screenshot with them underlined and it was still approved. But I also removed it to avoid problems.
image

I only left the license option with a link.
image

@blaise-tk Please take another look. If you need to change anything else, just contact me.

More other links I found and removed and fixed some translations that were missing in realtime-gui
- All translated original FAQs
- Additional new FAQs adapted to the reality of my country
Copy link
Member

@fumiama fumiama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. You may also want to add Portuguese link onto the main README file.

@fumiama fumiama added the documentation 📄文档说明 label Jan 16, 2024
@RafaelGodoyEbert
Copy link
Contributor Author

@Tps-F Tps-F merged commit 016e875 into RVC-Project:dev Jan 16, 2024
@fumiama
Copy link
Member

fumiama commented Jan 17, 2024

@fumiama I already added it, should I make a new PR? https://github.com/RafaelGodoyEbert/Retrieval-based-Voice-Conversion-WebUI/tree/main/docs/pt-BR

There're several README links at the beginning of README.md like this. See the last line. You can add Portuguese there.

Retrieval-based-Voice-Conversion-WebUI

一个基于VITS的简单易用的变声框架

madewithlove


Open In Colab
Licence
Huggingface

Discord

更新日志 | 常见问题解答 | AutoDL·5毛钱训练AI歌手 | 对照实验记录 | 在线演示

English | 中文简体 | 日本語 | 한국어 (韓國語) | Français | Türkçe

@fumiama
Copy link
Member

fumiama commented Jan 17, 2024

But don't worry. I will add that at my convinence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation 📄文档说明

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants