Conversation
larencozart
approved these changes
Apr 2, 2025
Contributor
larencozart
left a comment
There was a problem hiding this comment.
Everything tore down great!
One thing to consider is this line:
if (sg.GroupId && sg.GroupName?.toLowerCase().includes('rabbit')) { ids.push(sg.GroupId); }
I see you are deleting both the Rabbitory Control Panel security groups and all the Rabbitma instances' security groups by searching for the matching word "rabbit". While this does work for our use case, technically if our user might have a separate, unrelated security group named with the name "rabbit" in it.
This is just a small consideration. Not necessarily saying to change it. Just thought of that!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does more than anticipated -- deletes all broker instances, IAM roles, and security groups in all regions upon destroy.