NGRAVE ZERO brand import list integration#2831
NGRAVE ZERO brand import list integration#2831vvvvvv1vvvvvv merged 10 commits intoRabbyHub:developfrom
Conversation
he1m4n6a
left a comment
he1m4n6a
left a comment
There was a problem hiding this comment.
Reviewed, no security risk.
| .find((item) => item.type === keyring); | ||
| const alias = generateAliasName({ | ||
| brandName: brandName, | ||
| brandName: isNgraveZero ? 'NGRAVE ZERO' : brandName, |
There was a problem hiding this comment.
It is best to use brandName directly
There was a problem hiding this comment.
@heisenberg-2077 Without this explicit check, it would display as 'Keystone' because it shares the same keyring type: 'QR Hardware Wallet Device', can we do this for this specific case ?
There was a problem hiding this comment.
We need to modify the code to ensure that other brands that also use QRCode keyring will not be displayed as keystone. Please wait for us to modify it again to ensure that you do not need to do isNgraveZero recognition anywhere separately.
|
Please sync the latest code from the develop branch, add the NGRAVE ZERO as follows https://github.com/RabbyHub/Rabby/blob/develop/src/ui/views/NewUserImport/ImportList.tsx#L68 {
type: KEYRING_CLASS.HARDWARE.KEYSTONE,
logo: WALLET_BRAND_CONTENT[WALLET_BRAND_TYPES.NGRAVEZERO].icon,
brand: WALLET_BRAND_CONTENT[WALLET_BRAND_TYPES.NGRAVEZERO].brand,
}, |
@heisenberg-2077 should I update it ? And also remove the |
Yes, just add the wallet brand to the tipList array and test to see if it works as expected. |
@heisenberg-2077 worked perfectly, thank you! Also reverted the explicit checks and removed the unused i18n keys. |
5 participants
NGRAVE ZERO brand import list integration
Note:
bc-urpackage and NGRAVE ZERO shares the same device typeQR Hardware Wallet Device, explicit checks have been added to ensure proper handling.