fix warnings for optional parameters under PHP 8.0#280
Merged
infrastation merged 1 commit intoRackTables:masterfrom Jun 13, 2022
Merged
fix warnings for optional parameters under PHP 8.0#280infrastation merged 1 commit intoRackTables:masterfrom
infrastation merged 1 commit intoRackTables:masterfrom
Conversation
PHP Deprecated: Required parameter $X follows follows optional parameter
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running racktables under PHP 8.0 seems fine.
I collected some warnings:
The optional for seems not in use, Plugins not tested.
grep -r of the function names finds only complete function calls.
The included patch fixes the issue for me.