Conversation
While the native fastmcp api supports adding icons, it seems claude desktop shows icons as found in the default http /favicon.ico route at the moment. To handle this a custom favicon route was added
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds favicon support for the LamPyrid MCP server through two complementary mechanisms: native FastMCP icon registration using data URIs and a custom HTTP route for serving /favicon.ico. The implementation ensures the server's icon displays correctly in Claude Desktop and other MCP clients.
Key changes:
- Created
utils.pymodule for organizing custom HTTP routes - Registered favicon with FastMCP using the
iconsparameter with data URI embedding - Added custom
/favicon.icoroute to serve the icon file directly
Reviewed changes
Copilot reviewed 2 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lampyrid/utils.py | New module containing favicon serving route and route registration function |
| src/lampyrid/server.py | Added favicon icon initialization with FastMCP and registered custom HTTP routes |
| assets/favicon.png | New PNG favicon asset (48x48) |
| assets/favicon.ico | New ICO favicon asset |
| assets/logo-flame.png | New flame logo asset (binary file) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds favicon icon support through two complementary approaches:
/favicon.icoat root level for client requestsThis ensures the LamPyrid server icon displays correctly in Claude Desktop and other MCP clients.
Changes:
iconsparameter/favicon.icoroute using@mcp.custom_route()decoratorutils.pymodule for organizing custom HTTP routesResolves #18