Set apply_rules to true when creating transactions

[RadCod3]

Fixes #76

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e8a946c8-7786-41b0-abd4-1ef834c276db

📥 Commits

Reviewing files that changed from the base of the PR and between a88adfe and 0885d1a.

📒 Files selected for processing (1)

• src/lampyrid/services/transactions.py

---

📝 Walkthrough

Summary by CodeRabbit

• Bug Fixes
  • Transaction rules are now correctly applied to all transaction operations, including withdrawals, deposits, transfers, bulk operations, and updates.

Walkthrough

Updated the TransactionService class to set apply_rules=True when constructing TransactionStore and TransactionUpdate payloads across all transaction operations (withdrawals, deposits, transfers, and bulk/single creation), changing from apply_rules=False to enable rule firing for lampyrid-created transactions.

Changes

Cohort / File(s)	Summary
Transaction Rules Configuration src/lampyrid/services/transactions.py	Changed apply_rules flag from False to True across all transaction payload constructions (withdrawal, deposit, transfer, bulk atomic/non-atomic creation, and single updates) to enable rule execution on transaction creation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 With flags now set to True, the rules shall fly,
No more silent transactions passing by,
Each withdrawal, deposit, transfer aligned,
The rules engine awakens—order refined! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and accurately summarizes the main change: setting apply_rules to true when creating transactions.
Description check	✅ Passed	The description references the linked issue #76, which is directly related to the changeset addressing rules not being fired during transaction creation.
Linked Issues check	✅ Passed	The PR successfully addresses issue #76 by setting apply_rules=True across all transaction creation methods in TransactionService, directly resolving the identified cause of rules not firing.
Out of Scope Changes check	✅ Passed	All changes are scoped to the TransactionService's transaction creation methods and directly address the apply_rules flag requirement, with no out-of-scope modifications.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/76-rules-not-fired

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.56%. Comparing base (a88adfe) to head (0885d1a).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #78   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files          19       19           
  Lines        3118     3118           
=======================================
  Hits         3042     3042           
  Misses         76       76           

Flag	Coverage Δ
integration	97.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.