Conversation
|
@codex[agent] check over this before PR to ensure no underlying issues |
Reviewed current head c4f3d8a and 4f6d381; no additional issues spotted. cargo test currently fails locally because glib-2.0 (pkg-config) isn’t available in this environment. |
There was a problem hiding this comment.
Pull request overview
This PR focuses on improving sync performance by avoiding unnecessary file copies when only file metadata (mtime) changes, while also reducing repeated directory creation overhead during copy operations.
Changes:
- Add a “metadata update” operation in shadow planning/execution to reuse cached shadow content when file size matches and content hash matches, but mtime differs.
- Introduce a
DirectoryCacheto avoid repeatedcreate_dir_allcalls during batch copy execution, and switch set membership tracking fromBTreeSettoHashSet. - Plumb
compare.hash_on_metadata_changefrom config into sync planning, and add test coverage for the new reuse behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/sync_engine.rs | Adds metadata-only update actions, directory creation caching, and new hashing-based reuse path when only mtime changes. |
| src/config.rs | Exposes compare on ResolvedConfig so sync engine can use hash_on_metadata_change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| fn shadow_cache_reusable(path: &Path, size: u64) -> bool { | ||
| let Ok(metadata) = fs::metadata(path) else { | ||
| return false; | ||
| }; | ||
| metadata.is_file() && metadata.len() == size | ||
| } |
There was a problem hiding this comment.
shadow_cache_reusable only verifies that the existing shadow file is a regular file with a matching size. In the metadata-update reuse path this can incorrectly trust a shadow file that was modified out-of-band (mtime/content changed) but happens to keep the same size, and then the code overwrites its mtime and updates the manifest as if it were valid. Consider also validating the cached file’s timestamp against the previous manifest record (e.g., require metadata_matches_path(path, size, record.modified_millis)), or pass the expected modified_millis into this helper so reuse only happens when the cache still corresponds to the recorded version.
Adds a sync speed pass that skips redundant copies by reusing shadow cache when metadata changes but content hash is identical, controlled by new
compare.hash_on_metadata_changeconfig exposed in validation and wizard defaults. Introduces directory caching for file copies and ensures modified times are preserved from metadata for accurate sync manifests.Also adds packaging assets and scripts for Linux/macOS/Windows (icons, installers, release workflows) plus reset scripts and docs to distribute and recover the app.
Changes Made
compare.hash_on_metadata_changeand wire through sync planning to mark metadata-only updates instead of recopying files.Testing
cargo test(fails in current environment: missing systemglib-2.0/pkg-config)