-
Notifications
You must be signed in to change notification settings - Fork 42
Release v2.0.0 #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Release v2.0.0 #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add a urlhash to the model - write migrations to make the changes compatible for previous comments - add template to render permalink icon alongside comment Change render_content template tag - complete comment object is passed now so that urlhash can be obtainer easily. Add unit tests for general purpose utils Add tests for migration Move the permalink icon just left to the start of the comment Add tests to cover complete coverage Change max length for urlhash to 50 Fix generation of urlhash when there's a match - add tests to cover this.
- correct link to read the docs. - use div in footer for comment stlying, just makes the design less opinionated. - fix documentation for rendering all comments without pagination. - remove font-styling for comment content
- modify id to model_id -> maintains consistency throughout the project. - modify type to model_name -> maintaining consistency. Refactor some unittests and add a few for the additional code.
- make changes to webapi documentation. - remove redundant code and tests.
- unauthenticated users can comment anonymously by giving their email. - user can verify the comment by click on the link sent to their email. - the email can be sent in both html and text format. - comment only hits the database when it is authenticated. Add email field to the database -> change is backward compatible for previous comments. Closes #33
- since the parameter is directly taken from settings, it is no longer required here. - update documentation accordingly.
* update tests * add new anonymous setting for more flixibilty * add default image for anonymous
- this works for both django and DRF. - remove permissions that worked as mixin earlier for these parameters in drf, also corrects status code for wrong request to 400 from 403 in drf. - add a module for testing mixin. - add some other utility functions.
- separate the module for testing signals. Closes #61
- all creation of objects for test have been moved to setUpTestData from setUp. - some cleaning of tests. Closes #63
- update template tree. - update settings for anonymous commenting. - add a separate page for configurable variables for settings. - some other minor changes. Fixes #65
- add documentation regarding the action to confirm comment via web API. - correct some syntax and grammatical errors.
This will change content type and parent id mixins to validator classes. Fix bug in the method of changing flag state.
Collaborator
|
@Radi85 The GIF in the readme needs to be updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v2.0.0 release.