Makes this gem compatible with Zeitwerk.#39
Merged
Conversation
Zeitwerk is Rails 6's autoloading magician. It has one demand: if a file exists in the autoloading paths, that file has to define an appropriately-named constant. Because of reasons, we had to disable the Validating Enum a while back. (Ironically, because of Rails 6) The file still exists, but wasn't defining the module. This commit re-defines the module, but leaves it empty. This is a harmless change, and I've verified locally that it satisfies Zeitwerk. We don't have to also do this with the stuff under lib/ because that is not autoloaded by default.
armahillo
requested review from
a team and
jcavena
and removed request for
jcavena
jcavena
reviewed
Sep 2, 2022
Contributor
Author
|
fine by me! |
Ignore the last commit message. Well, partly ignore it. We'll just strip out validating enum stuff entirely since it's both not in use and is also confusing zeitwerk.
armahillo
force-pushed
the
make-validating-enum-zeitwerk-friendly
branch
from
6ca3246 to
98e5578
Compare
jcavena
approved these changes
Sep 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zeitwerk is Rails 6's autoloading magician. It has one demand: if a file
exists in the autoloading paths, that file has to define an
appropriately-named constant.
Because of reasons, we had to disable the Validating Enum a while back.
(Ironically, because of Rails 6) The file still exists, but wasn't
defining the module.
This commit re-defines the module, but leaves it empty. This is a
harmless change, and I've verified locally that it satisfies Zeitwerk.
We don't have to also do this with the stuff under lib/ because that is
not autoloaded by default.