feat(github-action): default severity-threshold to none (report-only)#148
Merged
Merged
Conversation
First-install no longer fails the build. Findings still post as PR comments and upload to the Security tab via SARIF, but the workflow exits 0 regardless of severity. When findings exist and the threshold is the default (none), the PR comment includes a one-line tip pointing to severity-threshold: high for opt-in enforcement. Rationale: rafter spans SAST + SCA + secrets where false positives are common; a first install that breaks the build on day one is the worst first impression and gets the action removed. Aligns with the Snyk / CodeQL / Semgrep default of surfacing through Code Scanning + PR comments rather than blocking. Existing users who set severity-threshold explicitly are unaffected. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Raftersecurity
approved these changes
May 31, 2026
This was referenced May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
severity-thresholddefault fromhightononeso a first install scans, comments, and uploads SARIF but never fails the build.severity-threshold: highfor opt-in enforcement.Why
Rafter spans SAST + SCA + secrets where false positives are common. The previous default (
high) meant any first install on a real repo would likely fail CI on day one — the worst possible first impression, and one that gets the action removed before users see the value. This aligns with how Snyk, CodeQL, and Semgrep default: surface findings through PR comments + the Security tab, and let teams opt into blocking once they've triaged the baseline.Behavior change for existing users
severity-thresholdexplicitly in their workflow: unaffected.highdefault: their builds will stop failing on critical/high findings. They'll see the new tip in the PR comment and can restore prior behavior withseverity-threshold: high.Test plan
severity-thresholdset → scan completes, PR comment includes the tip when findings exist, build does not fail.severity-threshold: highset → fail-on-high behavior preserved.severity-threshold: criticalset → fail-on-critical behavior preserved.Security review
rafteragent reviewed the diff — verdict GO, no findings. The newSEVERITY_THRESHOLDenv var passthrough uses the GitHub-recommendedenv:block pattern (not template interpolation into the script body); the new echo line is a static string; thenonebranch of the threshold-evaluation step already no-ops, so the default change has no logic regression.🤖 Generated with Claude Code