feat(agent): surface Hermes in verify/status/list detection (sable-gyw)#156
Merged
Conversation
Hermes install (--with-hermes), recipe, README, and dry-run plan already shipped MCP-only v0. This completes item (6) of sable-gyw: detection of an existing Hermes install across the three inspection commands, in both runtimes. Node: - verify.ts: checkHermes() — reads ~/.hermes/config.yaml (js-yaml safe load), asserts mcp_servers.rafter; registered in the verify results. - status.ts: Hermes added to the mcpAgents table + detectAgents() (JSON agents_detected). - components.ts: hermes.mcp ComponentSpec (list/enable/disable) mirroring the continueMcp install/uninstall shape but on the snake_case mcp_servers YAML. Python parity (agent.py + agent_components.py): _check_hermes, mcp_agents/_detect_agent_platforms entries, _hermes_mcp ComponentSpec. Tests: 7 Node detection tests (verify/status/list, --json shapes) and 6 Python tests (check + detect + component install/uninstall round-trip). Deserialization uses yaml.safe_load (Python) / js-yaml 4.1.1 load (safe schema); paths are fixed home()/.hermes literals; the written MCP entry is static. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Completes item (6) of sable-gyw — detection of an existing Hermes install across
rafter agent verify/status/list, in both the Node and Python runtimes. Hermes install (--with-hermes), the recipe, README badge/list, and the dry-run plan already shipped (MCP-only v0); this fills the remaining detection gap so an existing Hermes install surfaces everywhere the other 8 platforms do.Changes
Node
verify.ts—checkHermes()reads~/.hermes/config.yaml(js-yaml safe load), assertsmcp_servers.rafter; registered in the verify results array.status.ts— Hermes added to themcpAgentsstatus table and todetectAgents()(theagents_detectedJSON field).components.ts—hermes.mcpComponentSpec(powersagent list/enable/disable), mirroringcontinueMcpbut on the snake_casemcp_serversYAML shape.Python parity (
agent.py+agent_components.py)_check_hermes,mcp_agents+_detect_agent_platformsentries,_hermes_mcpComponentSpec.Docs
PLATFORM_PARITY_AUDIT.md— the stale "Hermes out of scope / track under rf-01b" note (rf-01b never existed as a bead) updated to record Hermes landed under sable-gyw.Tests
--json agents_detected, verify pass/warn--json,agent listcomponent presence + installed round-trip).agent-init-hermes.test.ts14/14 pass;agent-components+agent-commands95/95 pass._check_hermesnot-detected/pass/warn,_detect_agent_platforms, component registered + install/uninstall round-trip).test_agent_init.py88/88 pass.Full-suite pre-existing failures (version-parity drift 0.8.3↔0.8.0, Gemini-hooks flake sable-784, mcp-server-stdio, component-env) are unrelated and reproduce on the clean baseline.
Security
Diff parses/writes a local YAML config. Walked rafter-code-review (CWE Top 25):
yaml.safe_load(Python) / js-yaml 4.1.1load(safe schema) — no CWE-502; fixedhome()/.hermespaths — no CWE-22; static MCP entry, no subprocess — no CWE-78; shape-guarded, no recursive user-input merge — no CWE-1321.rafter secretsclean for changed files. Remoterafter runnot executed (noRAFTER_API_KEYin session).🤖 Generated with Claude Code