Skip to content

unity-cli@v1.0.13#14

Merged
StephenHodgson merged 2 commits intomainfrom
development
Oct 4, 2025
Merged

unity-cli@v1.0.13#14
StephenHodgson merged 2 commits intomainfrom
development

Conversation

@StephenHodgson
Copy link
Copy Markdown
Member

  • add a timeout to unity-hub process that force kills it if its still alive after 5s when tasks are completed

- add a timeout to unity-hub process that force kills it if its still alive after 5s when tasks are completed
Copilot AI review requested due to automatic review settings October 4, 2025 03:33
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a timeout mechanism to forcefully kill Unity Hub processes that don't terminate within 5 seconds after completing tasks, preventing hanging processes. It also updates the TryKillProcess function to accept custom signals.

  • Enhanced process termination with a 5-second timeout and force kill mechanism
  • Updated TryKillProcess function to support custom signals (SIGTERM/SIGKILL)
  • Improved signal handler cleanup and process management

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

File Description
src/utilities.ts Added signal parameter to TryKillProcess function with default SIGTERM
src/unity-hub.ts Implemented timeout-based force kill mechanism and improved signal handler cleanup
src/unity-editor.ts Removed unused ReadPidFile import
package.json Version bump to 1.0.13

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/utilities.ts
@StephenHodgson StephenHodgson merged commit 7836b16 into main Oct 4, 2025
16 checks passed
@StephenHodgson StephenHodgson deleted the development branch October 4, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants