unity-cli@v1.0.13#14
Merged
StephenHodgson merged 2 commits intomainfrom Oct 4, 2025
Merged
Conversation
Member
StephenHodgson
commented
Oct 4, 2025
- add a timeout to unity-hub process that force kills it if its still alive after 5s when tasks are completed
- add a timeout to unity-hub process that force kills it if its still alive after 5s when tasks are completed
There was a problem hiding this comment.
Pull Request Overview
This PR adds a timeout mechanism to forcefully kill Unity Hub processes that don't terminate within 5 seconds after completing tasks, preventing hanging processes. It also updates the TryKillProcess function to accept custom signals.
- Enhanced process termination with a 5-second timeout and force kill mechanism
- Updated TryKillProcess function to support custom signals (SIGTERM/SIGKILL)
- Improved signal handler cleanup and process management
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/utilities.ts | Added signal parameter to TryKillProcess function with default SIGTERM |
| src/unity-hub.ts | Implemented timeout-based force kill mechanism and improved signal handler cleanup |
| src/unity-editor.ts | Removed unused ReadPidFile import |
| package.json | Version bump to 1.0.13 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.