Skip to content

Experiments#16

Merged
StephenHodgson merged 12 commits intodevfrom
experiments
Oct 5, 2025
Merged

Experiments#16
StephenHodgson merged 12 commits intodevfrom
experiments

Conversation

@StephenHodgson
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings October 4, 2025 23:14
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces several utility functions for file operations and process management while refactoring existing code to improve line buffering and listener cleanup. The changes focus on enhancing Unity Editor execution and process handling capabilities.

  • Added new utility functions for file watching, process killing, and async operations
  • Improved line buffering logic in process output handling across multiple files
  • Refactored signal listener management to prevent memory leaks

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/utilities.ts Added new utility functions (delay, tailLogFile, waitForFileToBeCreatedAndReadable, waitForFileToBeUnlocked, KillProcess) and improved line buffering in Exec function
src/unity-hub.ts Updated to use new KillProcess function and improved line buffering logic
src/unity-editor.ts Major refactor to use new file utilities and improved process management
src/license-client.ts Improved signal listener cleanup to prevent memory leaks
src/android-sdk.ts Improved signal listener cleanup to prevent memory leaks
package.json Version bump to 1.0.14
.github/workflows/unity-build.yml Increased timeout and removed verbose flag

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/utilities.ts
Comment thread src/utilities.ts
Comment thread src/utilities.ts Outdated
@StephenHodgson StephenHodgson changed the base branch from main to dev October 4, 2025 23:32
@StephenHodgson StephenHodgson requested a review from Copilot October 4, 2025 23:39
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/utilities.ts Outdated
Comment thread src/utilities.ts Outdated
Comment thread src/utilities.ts Outdated
Comment thread src/utilities.ts Outdated
Comment thread src/unity-editor.ts Outdated
Comment thread src/unity-editor.ts Outdated
@StephenHodgson StephenHodgson merged commit 1c3b1a2 into dev Oct 5, 2025
3 of 4 checks passed
@StephenHodgson StephenHodgson deleted the experiments branch October 5, 2025 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants