Experiments#16
Merged
StephenHodgson merged 12 commits intodevfrom Oct 5, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces several utility functions for file operations and process management while refactoring existing code to improve line buffering and listener cleanup. The changes focus on enhancing Unity Editor execution and process handling capabilities.
- Added new utility functions for file watching, process killing, and async operations
- Improved line buffering logic in process output handling across multiple files
- Refactored signal listener management to prevent memory leaks
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utilities.ts | Added new utility functions (delay, tailLogFile, waitForFileToBeCreatedAndReadable, waitForFileToBeUnlocked, KillProcess) and improved line buffering in Exec function |
| src/unity-hub.ts | Updated to use new KillProcess function and improved line buffering logic |
| src/unity-editor.ts | Major refactor to use new file utilities and improved process management |
| src/license-client.ts | Improved signal listener cleanup to prevent memory leaks |
| src/android-sdk.ts | Improved signal listener cleanup to prevent memory leaks |
| package.json | Version bump to 1.0.14 |
| .github/workflows/unity-build.yml | Increased timeout and removed verbose flag |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
add ability to write to github env and output temp files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.