Skip to content

Conversation

@StephenHodgson
Copy link
Member

  • throw an error if android sdk installation is not ran in elevated terminal
  • remove inherited env from android sdk processes

- throw an error if android sdk installation is not ran in elevated terminal
- remove inherited env from android sdk processes
Copilot AI review requested due to automatic review settings October 18, 2025 00:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates unity-cli to version 1.3.3 with enhanced Android SDK installation handling on Windows. The changes focus on improving privilege detection and process isolation for Android SDK operations.

  • Added privilege elevation check for Windows Android SDK installations
  • Removed environment variable inheritance from Android SDK processes to improve isolation
  • Updated output handling to use stdout instead of stderr

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

File Description
src/utilities.ts Added isProcessElevated() function to check for administrator privileges on Windows
src/android-sdk.ts Enhanced Android SDK installation with privilege checks and environment isolation
package.json Version bump to 1.3.3
.github/workflows/unity-build.yml Added timeout for Unity setup step

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@StephenHodgson StephenHodgson merged commit 8736559 into main Oct 18, 2025
2 checks passed
@StephenHodgson StephenHodgson deleted the fix/android-sdk-2 branch October 18, 2025 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant