Skip to content

Conversation

@StephenHodgson
Copy link
Member

  • fix permission error when attempting to update editor metadata.hub.json

- fix permission error when attempting to update editor metadata.hub.json
Copilot AI review requested due to automatic review settings October 29, 2025 01:24
@StephenHodgson StephenHodgson merged commit 8cfca81 into main Oct 29, 2025
5 checks passed
@StephenHodgson StephenHodgson deleted the hot-fix branch October 29, 2025 01:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors file permission checking logic and improves CLI documentation, bumping the version from 1.5.1 to 1.5.2.

  • Moved file permission checks to be more specific and wrapped in proper error handling
  • Clarified CLI option descriptions to indicate comma-separated value format
  • Updated dependencies (commander, @types/node) and their transitive dependencies

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/unity-editor.ts Refactored permission checking to target the metadata file specifically instead of the editor root path, improving error handling and logging
src/cli.ts Reordered the --verbose option in the hub command and clarified help text for --build-targets and --modules options
package.json Version bump to 1.5.2 and dependency updates (commander ^14.0.2, @types/node ^24.9.2)
package-lock.json Lock file updates reflecting dependency version changes
Comments suppressed due to low confidence (1)

src/unity-editor.ts:330

  • This guard always evaluates to true.
            if (logTail && logTail.tailPromise) {

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants