Skip to content

Conversation

@StephenHodgson
Copy link
Member

  • updated license server configuration inputs to accept raw json string
  • added additional unit tests for license server configuration

- updated license server configuration inputs to accept raw json string
- added additional unit tests for license server configuration
Copilot AI review requested due to automatic review settings November 28, 2025 13:37
Copilot finished reviewing on behalf of StephenHodgson November 28, 2025 13:40
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for raw JSON input in license server configuration, extending the existing base64-only support. The version is bumped from 1.6.5 to 1.6.6.

  • Added resolveServicesConfigContent method to handle raw JSON, base64 encoded JSON, or file path inputs
  • Implemented unit tests to validate the new JSON parsing and base64 decoding functionality
  • Updated documentation to reflect the new input options and added Node.js version requirement

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/license-client.ts Added tryParseJson and resolveServicesConfigContent methods to support raw JSON and base64 encoded JSON inputs; updated Windows PROGRAMDATA fallback to be consistent with existing code
tests/license-client.test.ts New test suite covering raw JSON input, base64 encoded JSON input, and validation of empty and invalid inputs
README.md Updated --config parameter documentation to mention raw JSON support; added Node v22.12 minimum version requirement
package.json Version bump to 1.6.6
package-lock.json Version bump to 1.6.6

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@StephenHodgson StephenHodgson merged commit 05b48c4 into main Nov 28, 2025
4 of 7 checks passed
@StephenHodgson StephenHodgson deleted the development branch November 28, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant