Skip to content

Conversation

@StephenHodgson
Copy link
Member

@StephenHodgson StephenHodgson commented Nov 28, 2025

  • fix a race condition between setting services configuration and acquire license request. Waits for license client to recognize license server before attempting to acquire.

- fix a race condition between setting services configuration and acquire license request. Waits for license client to recognize license server before attempting to aquire
Copilot AI review requested due to automatic review settings November 28, 2025 15:31
Copilot finished reviewing on behalf of StephenHodgson November 28, 2025 15:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a race condition in floating license activation by ensuring the license client recognizes the license server configuration before attempting to acquire a license. The fix introduces a polling mechanism that monitors the Unity licensing client log file for confirmation that the server URL has been configured.

  • Adds waitForLicenseServerConfiguration() method that polls the licensing client log file until it confirms the floating license server is configured
  • Modifies the floating license activation flow to call Context() and wait for server configuration before acquiring the license
  • Includes comprehensive test coverage for the new waiting mechanism

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.

File Description
src/license-client.ts Implements getClientLogSize() and waitForLicenseServerConfiguration() methods to poll the log file for server configuration, and updates Activate() to use these methods for floating licenses
tests/license-client.test.ts Adds test imports and new test suite for waitForLicenseServerConfiguration(), plus updates existing test to mock the new methods
package.json Updates version from 1.6.7 to 1.6.8
package-lock.json Updates dependency versions including baseline-browser-mapping and should update package version to match package.json

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@StephenHodgson StephenHodgson merged commit 30388b0 into main Nov 28, 2025
19 of 20 checks passed
@StephenHodgson StephenHodgson deleted the fix/services-config-race branch November 28, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant