Skip to content

Conversation

@StephenHodgson
Copy link
Member

  • when returning license, skip GetActiveEntitlements for floating licenses

- when returning license, skip GetActiveEntitlements for floating licenses
Copilot AI review requested due to automatic review settings November 28, 2025 23:01
@StephenHodgson StephenHodgson merged commit e60a691 into main Nov 28, 2025
5 checks passed
@StephenHodgson StephenHodgson deleted the fix/floating-checkin branch November 28, 2025 23:01
Copilot finished reviewing on behalf of StephenHodgson November 28, 2025 23:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes the license deactivation flow by avoiding unnecessary entitlement checks for floating licenses. The key insight is that GetActiveEntitlements() only tracks personal and professional licenses, not floating licenses, making the check redundant and potentially problematic for floating license returns.

Key Changes:

  • Simplified the Deactivate() method to directly call returnLicense() without pre-checking entitlements
  • Moved the entitlement check into returnLicense() for non-floating licenses only, where it's actually useful
  • Added early return logic with informative logging when no active non-floating license is found

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
src/license-client.ts Refactored license return logic to skip GetActiveEntitlements() for floating licenses and add pre-return validation for non-floating licenses
package.json Version bump to 1.7.1
package-lock.json Version bump to 1.7.1

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant