unity-setup@v1.2.6 #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed the version check if hub was installed - fixed the legacy url check fallback - updated linux dependency installs for older editor versions
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the unity-setup action to version 1.2.6 with improvements to Unity Hub installation and version checking logic. The main purpose is to optimize the Hub installation process and improve dependency management for different Unity Editor versions on Linux.
- Removed the automatic version check for Unity Hub when it's already installed
- Fixed the legacy URL check fallback mechanism for fetching Unity version information
- Added version-specific Linux dependency installation for older Unity Editor versions
Reviewed Changes
Copilot reviewed 4 out of 9 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/unity-hub.ts | Refactored Hub version checking logic, improved fallback URL handling, and added Linux dependency installation |
| src/install-unityhub-linux.sh | Removed hardcoded SSL library installation to allow version-specific handling |
| src/install-linux-dependencies.sh | New script for installing version-specific dependencies for Unity Editor on Linux |
| package.json | Version bump to 1.2.6 and minor dependency updates |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 7 out of 12 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.