Skip to content

Conversation

@StephenHodgson
Copy link
Member

  • updated .xcodeproj search to exclude GameAssembly, UnityFramework, and Pods project files

- updated .xcodeproj search to exclude GameAssembly, UnityFramework, and Pods project files
@StephenHodgson StephenHodgson requested a review from Copilot March 25, 2025 21:25
@StephenHodgson StephenHodgson marked this pull request as ready for review March 25, 2025 21:26
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the unity-xcode-builder to v1.1.7 by modifying the Xcode project search logic to exclude GameAssembly, UnityFramework, and Pods project files, and by updating the module exports.

  • Updated the GitHub Actions workflow trigger to include additional pull_request types and add a check to ignore draft PRs.
  • Modified src/xcode.ts to export key functions and add exclusion logic based on project names.

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

File Description
.github/workflows/validate.yml Adjusted workflow trigger events and added a draft check.
src/xcode.ts Exported several functions and added exclusion logic for projects.
Files not reviewed (1)
  • package.json: Language not supported
Comments suppressed due to low confidence (5)

src/xcode.ts:22

  • [nitpick] Consider renaming 'GetProjectDetails' to 'getProjectDetails' to follow camelCase naming conventions, consistent with other function names in the file.
export async function GetProjectDetails(): Promise<XcodeProject> {

src/xcode.ts:165

  • [nitpick] Consider renaming 'ArchiveXcodeProject' to 'archiveXcodeProject' for consistency with camelCase function naming conventions used elsewhere.
export async function ArchiveXcodeProject(projectRef: XcodeProject): Promise<XcodeProject> {

src/xcode.ts:247

  • [nitpick] Consider renaming 'ExportXcodeArchive' to 'exportXcodeArchive' to maintain consistency in function naming style.
export async function ExportXcodeArchive(projectRef: XcodeProject): Promise<XcodeProject> {

src/xcode.ts:528

  • [nitpick] Consider renaming 'ValidateApp' to 'validateApp' for consistency with JavaScript camelCase naming conventions.
export async function ValidateApp(projectRef: XcodeProject) {

src/xcode.ts:609

  • [nitpick] Consider renaming 'UploadApp' to 'uploadApp' to follow camelCase naming conventions used in the rest of the code.
export async function UploadApp(projectRef: XcodeProject) {

@StephenHodgson StephenHodgson merged commit eb51a14 into main Mar 25, 2025
11 checks passed
@StephenHodgson StephenHodgson deleted the development branch March 25, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant