ci: remove borales/actions-yarn and peter-evans/create-pull-request#56
Merged
Conversation
Drops two third-party actions from .github/workflows/: - borales/actions-yarn (in unit-tests.yml): replaced with corepack + yarn install --frozen-lockfile, using setup-node's built-in yarn cache. - peter-evans/create-pull-request (in update-ofac.yml): replaced with direct shell commands using the gh CLI (preinstalled on GitHub-hosted runners). The replacement preserves the same cron-idempotent behaviour - if the branch already has an open PR, the force-push updates it in place; otherwise a new PR is opened. An explicit `permissions:` block declares the `contents: write` and `pull-requests: write` scopes the new shell steps need (the default GITHUB_TOKEN is read-only by default).
mesquka
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes every non-
actions/*action from.github/workflows/:borales/actions-yarninunit-tests.yml→corepack enable+yarn install --frozen-lockfile.peter-evans/create-pull-requestinupdate-ofac.yml→ direct shell using theghCLI (preinstalled on GitHub-hosted runners). The replacement preserves the action's cron-idempotent behaviour: if the branch already has an open PR, the force-push updates it in place; otherwise a new PR is created.Adds an explicit
permissions:block onupdate-ofac.yml(contents: write,pull-requests: write) because the defaultGITHUB_TOKENis read-only, and the shell steps now need write scopes to push the branch and open the PR.Why
Both actions ran inside our workflow with the
GITHUB_TOKEN's scopes.peter-evans/create-pull-requestis the more concerning of the two — it's an action that, by design, runsgit pushand thegh prAPI against our repo with the live token. Replacing it with a handful of shell lines removes that intermediary and makes the required permissions explicit and minimal.